Skip to content

Do not write anything into the log file when there are no queries to log #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hra687261 merged 1 commit into from
Nov 25, 2025
Merged

Do not write anything into the log file when there are no queries to log #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/smtml/utils.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,19 @@ let write =
| Some path ->
let log_entries : (string * Expr.t list * int64) list ref = ref [] in
let close () =
try
let oc =
(* open with wr/r/r rights, create if it does not exit and append to
if not (List.is_empty !log_entries) then
try
let oc =
(* open with wr/r/r rights, create if it does not exit and append to
it if it exists. *)
Out_channel.open_gen
[ Open_creat; Open_binary; Open_append ]
0o644 (Fpath.to_string path)
in
Marshal.to_channel oc !log_entries [];
Out_channel.close oc
with e ->
Fmt.failwith "Failed to write log: %s@." (Printexc.to_string e)
Out_channel.open_gen
[ Open_creat; Open_binary; Open_append ]
0o644 (Fpath.to_string path)
in
Marshal.to_channel oc !log_entries [];
Out_channel.close oc
with e ->
Fmt.failwith "Failed to write log: %s@." (Printexc.to_string e)
in
at_exit close;
Sys.set_signal Sys.sigterm (Sys.Signal_handle (fun _ -> close ()));
Expand Down
Loading