Skip to content

Conversation

@tiferrei
Copy link
Contributor

@tiferrei tiferrei commented Dec 1, 2025

This PR adds a to_json method for Statistics.t.

Note: This method uses Yojson.Basic.t for consistency with the rest of the repo. In the future it is probably best to convert the usages to Yojson.Safe.t.

feat: Statistics.to_json
@tiferrei tiferrei requested a review from a team as a code owner December 1, 2025 18:46
Copy link
Member

@filipeom filipeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like the colibri2 CI is broken because https://git.frama-c.com/pub/ is acting up again 😢

@tiferrei
Copy link
Contributor Author

tiferrei commented Dec 1, 2025

Yes I had to remove those repos locally. I think the links are dead :(

@hra687261
Copy link
Contributor

hra687261 commented Dec 1, 2025

Not permanently dead (I hope), it seems to be some kind of ddos because every once in a while it works ...
The Colibri2 CI should probably be disabled for the meantime, until that gets fixed at some point ...

@filipeom
Copy link
Member

filipeom commented Dec 1, 2025

Not permanently dead (I hope), it seems to be some kind of ddos because every once in a while it works ...

Yeah, it does seem a bit intermittent. I changed the opam-repositories fields in CI to use https://opam.ocaml.org which fixed the failures to fetch packages from the frama-c gitlab. Unfortunately, since colibri2 is pinned it will fail to clone the repo and fail because it will use the latest colibri2 pacakge in opam-repo 😢

The Colibri2 CI should probably be disabled for the meantime, until that gets fixed at some point ...

I'll leave it on for now since it is not required to merge PRs. Hopefully it will be fixed soon

@filipeom filipeom merged commit 99674a6 into formalsec:main Dec 1, 2025
10 of 11 checks passed
@filipeom
Copy link
Member

filipeom commented Dec 1, 2025

Thanks again! I'll open a issue to reminds us to change to Yojson.Safe.t 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants