Skip to content

feat: add resource parameter in client credentials requests#543

Merged
flemzord merged 1 commit into
mainfrom
feat/client-credentials-resource
Feb 3, 2026
Merged

feat: add resource parameter in client credentials requests#543
flemzord merged 1 commit into
mainfrom
feat/client-credentials-resource

Conversation

@gfyrag
Copy link
Copy Markdown
Contributor

@gfyrag gfyrag commented Jan 27, 2026

No description provided.

@gfyrag gfyrag requested a review from a team as a code owner January 27, 2026 11:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 27, 2026

Walkthrough

A new optional Resource field is added to the ClientCredentialsRequest struct in the OIDC token request module. This extends the token request payload schema to support specifying a resource parameter in client credentials grant flows.

Changes

Cohort / File(s) Summary
Struct field addition
oidc/token_request.go
Added public Resource field with schema:"resource,omitempty" tag to ClientCredentialsRequest struct for optional resource parameter support in token requests

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A resource field hops in with grace,
Client credentials finds its place,
The schema stretches, optional and free,
One tiny change, yet helpful to see! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the purpose and context of adding the resource parameter to client credentials requests.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a resource parameter to client credentials requests, which matches the added Resource field in ClientCredentialsRequest struct.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/client-credentials-resource

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.76%. Comparing base (6c6ceb8) to head (f65b767).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   28.76%   28.76%           
=======================================
  Files         172      172           
  Lines        6804     6804           
=======================================
  Hits         1957     1957           
  Misses       4730     4730           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flemzord flemzord added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 782f024 Feb 3, 2026
7 checks passed
@flemzord flemzord deleted the feat/client-credentials-resource branch February 3, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants