Skip to content

feat: add new GetAWSIAMAuthConnector function#544

Merged
sylr merged 1 commit into
mainfrom
feat/standalone-aws-iam-bun-connector
Jan 29, 2026
Merged

feat: add new GetAWSIAMAuthConnector function#544
sylr merged 1 commit into
mainfrom
feat/standalone-aws-iam-bun-connector

Conversation

@sylr
Copy link
Copy Markdown
Contributor

@sylr sylr commented Jan 29, 2026

No description provided.

@sylr sylr requested a review from a team as a code owner January 29, 2026 10:07
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 29, 2026

Walkthrough

A new public helper function GetAWSIAMAuthConnector was added to extract AWS IAM connector construction logic, and ConnectionOptionsFromFlags was refactored to use this helper instead of inline configuration loading.

Changes

Cohort / File(s) Summary
AWS IAM Connector Extraction
bun/bunconnect/flags.go
Added exported GetAWSIAMAuthConnector function that initializes AWS SDK config and returns a connector factory. Refactored ConnectionOptionsFromFlags to use this new helper, replacing inline connector construction. Added import for AWS SDK package.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A function extracted clean,
From flags to IAM's gleam,
Reusable, neat, and lean,
The AWS connector's dream! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the purpose, rationale, and any relevant context for the AWS IAM connector refactoring.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: extracting AWS IAM connector logic into a new reusable GetAWSIAMAuthConnector function.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/standalone-aws-iam-bun-connector

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Sylvain Rabot <sylvain@formance.com>
@sylr sylr force-pushed the feat/standalone-aws-iam-bun-connector branch from 0f82b0d to 02c85a9 Compare January 29, 2026 10:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.05%. Comparing base (79fe6a4) to head (02c85a9).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
bun/bunconnect/flags.go 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   29.22%   29.05%   -0.18%     
==========================================
  Files         174      175       +1     
  Lines        6943     7139     +196     
==========================================
+ Hits         2029     2074      +45     
- Misses       4797     4946     +149     
- Partials      117      119       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylr sylr added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit 4b5486f Jan 29, 2026
5 of 7 checks passed
@sylr sylr deleted the feat/standalone-aws-iam-bun-connector branch January 29, 2026 20:29
@sylr sylr restored the feat/standalone-aws-iam-bun-connector branch March 13, 2026 10:31
@sylr sylr deleted the feat/standalone-aws-iam-bun-connector branch March 13, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants