chore(regions): bump to 3.10.0 with go-libs migrator index fix#352
Draft
chore(regions): bump to 3.10.0 with go-libs migrator index fix#352
Conversation
Bumps ledger and payments pinned versions to pull in the go-libs migrator index name fix (formancehq/go-libs#594, backported as v2.2.5 / v3.6.2 / v4.1.4). Targets new patch tags that will be cut once the linked backport PRs merge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bumps payments v3.0/v3.1 stack pins to v3.0.20 (formancehq/payments#706, draft) and orchestration v3.1/v3.2 stack pins to v2.4.2 / v2.6.1 (formancehq/flows#173 / #172). v3.0 stack orchestration v2.1.1 stays untouched: no release/v2.1 branch exists on flows, so no backport target. Needs separate decision (bump to v2.4.x line or accept the bug there). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Webhooks main has the go-libs v2.2.5 fix merged (formancehq/webhooks#146) but no new tag was cut yet. Bumps all stack pins to v2.3.1, which needs to be tagged from webhooks main HEAD before this PR can ship. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bumps v3.0 stack orchestration v2.1.1 -> v2.1.2 (formancehq/flows#174, backport on freshly-created release/v2.1) and v3.2 stack transactionplane v0.2.1 -> v0.2.2 (formancehq/transaction-plane#85, backport on freshly- created release/v0.2). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
formancehq/transaction-plane#84 and #85 were closed by paul-nicolas in favor of a full upgrade to go-libs v5 (separate PR, not yet opened). v0.2.2 tag will not be cut from the release/v0.2 branch I created. This stack pin remains vulnerable until Paul ships the v5 upgrade and this PR will need a separate update once that lands. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps regions chart to 3.10.0 and updates ledger / payments / orchestration / webhooks / transactionplane pinned versions across stack versions to pull in the go-libs migrator index name fix (formancehq/go-libs#594, backported as
v2.2.5/v3.6.2/v4.1.4).The bug: a hardcoded
idx_version_idunique-index name ingo-libs/pkg/storage/migrations/migrator.gocollides between two migrators sharing a schema (PostgreSQL scopes index names per-schema, not per-table). The second migrator'sCREATE UNIQUE INDEX IF NOT EXISTSbecomes a silent no-op, leaving itsINSERT ... ON CONFLICT (version_id)failing withSQLSTATE 42P10at startup. Triggered in prod by enabling the NATS broker circuit breaker (which writes its owncircuit_breaker_migrationstable into the broker schema).Changes per stack
v2.3.0→v2.3.1v2.2.58→v2.2.59v2.3.0→v2.3.1v2.2.58→v2.2.59v3.0.18→v3.0.20v2.3.0→v2.3.1v2.1.1→v2.1.2release/v2.1)v2.3.17→v2.3.18v3.0.18→v3.0.20v2.3.0→v2.3.1v2.4.1→v2.4.2v2.4.2→v2.4.4v3.2.0→v3.2.1v2.3.0→v2.3.1v2.6.0→v2.6.1v0.2.1→v0.2.2release/v0.2)Versions intentionally NOT bumped
v2.0stack — not vulnerableAll pins (
ledger v2.0.24,payments v2.0.32,webhooks v2.0.24,orchestration v2.0.24,reconciliation v2.0.24, etc.) come from the legacyformancehq/stackmonorepo. The monorepo ships its ownlibs/go-libs/migrations/migrator.go— an older implementation that does not have theidx_version_idunique-index pattern and does not useINSERT ... ON CONFLICT (version_id). The bug we're fixing here was introduced in the standaloneformancehq/go-libsrepo (extracted later). Not vulnerable. Same applies to thev2.0.xpins ofpaymentsandorchestrationreferenced by thev2.1andv2.2stacks.Status of all backport PRs
Already merged on main (need a tag cut)
v2.3.0predates the fix. Cutv2.3.1from main HEAD.Open backport PRs (ready)
Open, draft (heavy diff)
v3.0.0-alpha.2and Go 1.23, and the smallest patched go-libs requires Go 1.24.go mod tidycascades into ~280 lines of transitive bumps. Build is clean but invasive. Alternative: shift v3.0/v3.1 stacks to payments v3.1.x line (where #703 covers the fix with a much smaller diff) instead of merging #706.Already merged + tagged
Pending follow-ups (separate from this PR)
circuitBreakerEnabled=truesetting was changed — a config change should trigger a reconcile of dependent stack pods. Separate from the go-libs bug.v2.0stack pins service tags from the legacyformancehq/stackmonorepo. Consider a follow-up PR to mark this stack EOL.Blocking
This PR is draft because the target tags (
ledger v2.2.59/v2.3.18/v2.4.4,payments v3.0.20/v3.2.1,orchestration v2.1.2/v2.4.2/v2.6.1,webhooks v2.3.1,transactionplane v0.2.2) don't exist yet — they'll be cut from the linked branches once those PRs merge / tags are pushed. Promote to ready once each tag is available.🤖 Generated with Claude Code