FIO-9918 Removed potential trailing slashes in baseURL#251
Open
antonSoftensity wants to merge 1 commit intomaster_oldfrom
Open
FIO-9918 Removed potential trailing slashes in baseURL#251antonSoftensity wants to merge 1 commit intomaster_oldfrom
antonSoftensity wants to merge 1 commit intomaster_oldfrom
Conversation
brendanbond
requested changes
Jun 5, 2025
Contributor
brendanbond
left a comment
There was a problem hiding this comment.
Can we do something besides a brittle regex test here? I'd probably reach for new URL in this case to create a deterministic URL every time.
Also, please don't forget tests!
johnformio
approved these changes
Jun 11, 2025
Contributor
|
@antonSoftensity I know you said using the URL object created more object, but I think we should try again. I would start with changing the type of any it's just a larger refactor this way, but way safer in the long run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9918
Description
Removed trailing slashes from setBaseUrl, which caused incorrect requests in some cases. Switching requests to URL object was attempted, but it created a lot more issues.
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
Use this section to list any dependent changes/PRs in other Form.io modules
How has this PR been tested?
Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning
Checklist: