This repository was archived by the owner on Jan 22, 2018. It is now read-only.
refactor(radio, select): change model in view types#48
Open
sciborrudnicki wants to merge 4 commits intoformly-js:masterfrom
Open
refactor(radio, select): change model in view types#48sciborrudnicki wants to merge 4 commits intoformly-js:masterfrom
sciborrudnicki wants to merge 4 commits intoformly-js:masterfrom
Conversation
…lect Change variables to manipulate easy on options and add groups if first item got label attribute. In older way if you would like to change option name you cannot do it properly.
Author
|
Forgot about tests |
Current coverage is 100% (diff: 100%)@@ master #48 diff @@
===================================
Files 19 19
Lines 100 100
Methods 0 0
Messages 0 0
Branches 0 0
===================================
Hits 100 100
Misses 0 0
Partials 0 0
|
gmanriqueUy
suggested changes
Jan 2, 2017
| aria-label="{{to.options[$index].ariaLabel}}" | ||
| class="{{to.options[$index].className}}" | ||
| ng-disabled="to.options[$index].disabled || to.disabled" | ||
| ng-value="to.options[$index].value"> |
There was a problem hiding this comment.
I would add the possibility of define the value property name.
Like this ng-value="to.options[$index][to,valueProp || 'value']".
Same goes to the next line,
{{to.options[$index].name
replaced by
{{to.options[$index][to.labelProp || 'name']
What do you say?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change variables to manipulate easy on options and add groups if first item got label attribute. In older way if you would like to change option name you cannot do it properly.