Skip to content

support module #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

support module #859

wants to merge 86 commits into from

Conversation

forrestguice
Copy link
Owner

@forrestguice forrestguice commented Jan 18, 2025

  • refactors project source to remove explicit imports to the android support library.
  • adds :app:support, app:support-test modules that wrap the android support library classes.

replaces support annotations (@nonnull, @nullable)
DrawerLayout, NavigationView, ActionBarDrawerToggle
AppBarLayout, CoordinatorLayout, Toolbar
ContextCompat
ViewCompat
TabLayout, TabItem, ViewPager
ConstraintLayout, Guideline, Flow
AppCompatCheckBox, AppCompatImageButton, AppCompatImageView, AppCompatSpinner, AppCompatTextView, AppCompatCheckedTextView, AppCompatAutoCompleteTextView
CardView, FloatingActionButton, SwitchCompat, NestedScrollView, LinearLayoutCompat
ResourcesCompat
ColorUtils
DrawableCompat, ImageViewCompat
ActivityCompat, CompoundButtonCompat, MenuItemCompat
BottomSheetDialogFragment
RecyclerView
DialogFragment
ActivityOptionsCompat
RecyclerViewUtils (SimpleItemAnimator)
PopupMenu
ActionBar (getSupportActionBar)
AppCompatActivity
CallSuper, LayoutRes, StringRes
FragmentManager
FragmentManager (FragmentPagerAdapter, FragmentStatePagerAdapter)
BottomSheetDialog, BottomSheetBehavior (now wrapped by BottomSheetBehaviorCompat)
BottomSheetDialog
AppCompatActivity
DataInteraction, ViewInteraction
adds `:app:support` module that extends/wraps support library classes
@forrestguice forrestguice added this to the v0.16.5 milestone Jan 18, 2025
@forrestguice forrestguice changed the title support support module Jan 18, 2025
RecyclerView.ItemDecoration
NotificationCompat
split support test classes into separate module `support-test`
lint
This was referenced Feb 4, 2025
@forrestguice
Copy link
Owner Author

forrestguice commented Feb 14, 2025

Was ready to merge this but now I'm having second thoughts.

Introducing a "support layer" would allow the app to be built using both the support libraries or androidx (using different build flavors), but I'm uncertain about future maintainability. It may be better to just "bite the bullet" and make a full switch to androidx instead. My desire to support both is rooted in stubborness (I don't appreciate finding myself in this position - thanks Google), and this is one way that can be achieved.

@forrestguice forrestguice reopened this Feb 14, 2025
@forrestguice forrestguice removed this from the v0.16.5 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant