Skip to content

Replace all instances of Dropdown with ListBox, and remove the Dropdown component #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft

Replace all instances of Dropdown with ListBox, and remove the Dropdown component #173

wants to merge 34 commits into from

Conversation

mkrause
Copy link
Collaborator

@mkrause mkrause commented Apr 20, 2025 •
edited
Loading

TO DO:

  • When the dropdown menu is open, and the user hits "Enter", the focused item should be selected (and the menu closed).
  • Fix the issue where the ListBoxLazy infinite scroll will load the next page even when the user has not yet scrolled down.

mkrause added 30 commits February 27, 2025 18:10
@mkrause
Simplify Breadcrumbs styling to fix link colors.
484cd26
@mkrause
Implement ListBox component (initial prototype).
79cb285
@mkrause
Implement requireIntent.
1263dc6
@mkrause
ListBox: implement type ahead.
ff2f4b9
@mkrause
Implement ListBox.Header and ListBox.Action.
b348aea
@mkrause
ListBox: implement disabled + 'sticky' prop for Action.
e052962
@mkrause
Add example of ListBox in a <form> element.
c2198dc
@mkrause
Implement ListBoxLazy (initial prototype).
52b4ca0
@mkrause
ListBoxLazy: implement infinite scroll.
ec8c57d
@mkrause
ListBox: before zustand migration.
a4f23f0
@mkrause
ListBoxStore: before removing ItemTarget.
fa0f544
@mkrause
Work on ListBoxLazy.
7447da3
@mkrause
ListBox: Before going back to 'virtual focus' on the parent list box.
b1321c1
@mkrause
Switching back to roving tabindex.
3430a0e
@mkrause
ListBoxLazy: always render the focused item.
58da207
@mkrause
Implement VirtualItemKeys.
ab42320
@mkrause
VirtualItemKeys: fixes.
8d8d943
@mkrause
Fix issues with elements not focusing on keyboard navigation.
8ca50e7
@mkrause
ListBox: Clean up code.
31b88d1
@mkrause
Merge branch 'master' into feature/gh-165-implement-list-box
59a0b1b
@mkrause
Update package lock.
7e3a561
@mkrause
Add missing license headers.
adad805
@mkrause
Merge branch 'master' into feature/gh-165-implement-list-box
850fd73
@mkrause
ListBox: fix disabled state, use in <form> elements.
c46b053
@mkrause
ListBox: Fix sticky headers.
2906323
@mkrause
ListBox: Implement workaround for sticky actions 'bleed through'.
1d45e77
@mkrause
Remove comment.
55b9b2b
@mkrause
ListBox: make 'virtualItemKeys' an optional prop.
e853ad9
@mkrause
ListBox: implement onToggle event handler for focus management with p…
0579d2e 
…opover.
@mkrause
Replace all instances of Dropdown with ListBox, and remove the Dropdo…
32da639 
…wn component.
@mkrause mkrause self-assigned this Apr 20, 2025
@mkrause mkrause mentioned this pull request Apr 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkrause mkrause

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Banner: text overflow word breaking not working correctly Improve Dropdown and Select components
1 participant
@mkrause