Skip to content

(#214) Integrate ComboBox component into MultiSearch #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mkrause wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

(#214) Integrate ComboBox component into MultiSearch #215

mkrause wants to merge 3 commits into from

Conversation

@mkrause
Copy link
Collaborator

@mkrause mkrause commented May 18, 2025 •
edited
Loading

Resolves #214
Resolves #223

TODO:

  • Select: arrow down/up opens the dropdown but doesn't focus the item.
  • Select: clicking on the arrow doesn't close the menu when open.
  • Fix MultiSearch to work with the new ComboBox component.
  • Need to sort the items in a ListBox. Out of order key navigation can be reproduced somewhat consistently in the ComboBox autocomplete story.
  • Remove the "TEMP" code in DropdownMenuProvider.
  • Type errors.

@mkrause mkrause added this to the Baklava v1.0 milestone May 18, 2025
@mkrause mkrause self-assigned this May 18, 2025
@mkrause mkrause mentioned this pull request May 19, 2025
Open
@mkrause mkrause mentioned this pull request Jun 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mkrause mkrause

Labels

None yet

Projects

None yet

Milestone

Baklava v1.0

Development

Successfully merging this pull request may close these issues.

User has to click twice outside of DataTableEager.MultiSearch to close dropdown Integrate ComboBox component into MultiSearch

2 participants

@mkrause