-
Notifications
You must be signed in to change notification settings - Fork 3
Banner component update #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a982cc4 to
9472d15
Compare
|
This apparently caused a regression in Chrome v121, which is the version used on Chromatic at the moment: I cannot reproduce this issue in any current browser, and just from the screenshots I have not been able to deduce the cause of this issue. It's not as simple as the icon being too large, it seems that the icon takes up the full width of the icon + title element, all the while the title text is hidden/collapsed. So the icon actually scales with the title text for some weird reason. So this would need some investigation on an actual Chrome v121 instance. On the other hand, Chrome v121 was released in January 2024, so it's a year old by now and maybe we can ignore this as an old browser bug? Chromatic will update to a newer Chrome version in February 2025. |

This PR:
Bannercomponent.Alertcomponent, which is a duplication.Banner.It also:
tsconfig.jsonfiles.SegmentedControlandTooltipcomponents (which I needed for Banner).TODO: