-
Notifications
You must be signed in to change notification settings - Fork 13
953: Add color themes #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dcmouyard
wants to merge
18
commits into
5.x-RC
Choose a base branch
from
953-add-color-themes
base: 5.x-RC
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.4.2 release PR
kmonahan
requested changes
May 16, 2025
Collaborator
kmonahan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm marking this as "Request changes" to indicate that I don't think it's ready to merge, but that's because Github doesn't have a "Discussion needed" review status.
Items for discussion:
- Does color themes come up often enough to be needed in Gesso? I'm only aware of one project where we've done it. That said, if it doesn't add too much complexity or overhead to a project without color themes, I'm not opposed to it. (Same logic applies to light mode/dark mode support, which I've also considered adding.)
- This PR has some major changes to how design tokens in Gesso are handled. It feels large enough to me that I think it should be held until Gesso 6; I don't think it's a minor release item.
- If we're going to switch to CSS variables for colors (a thing I am for), why not do the same for our other design tokens? Removing Sass is on the Gesso 6 roadmap, and this PR feels like the first step down that path.
- I think we need to align on a variable naming convention between Gesso for React and Gesso for Drupal. Gesso for React already uses CSS variables to similar purpose under different names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #953.
Hopefully the updated README makes it clear how this works: