Skip to content

806 php linting tweaks #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
coreylafferty wants to merge 3 commits into
base: 806-fix-phpcs-and-phpstan-errors
Choose a base branch
from
Open

806 php linting tweaks #987

coreylafferty wants to merge 3 commits into from

Conversation

@coreylafferty
Copy link
Member

@coreylafferty coreylafferty commented Jan 9, 2026 •
edited
Loading

I ran into some additional phpstan errors when working with these changes on a real project, so I make some tweaks here.

@coreylafferty coreylafferty changed the title 806 php linting tweaks, fix for add_attributes 806 php linting tweaks Jan 9, 2026
kmonahan
kmonahan approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@kmonahan kmonahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now. Per #945, I'm inclined to remove these commands entirely, but in the mean time, good with anything that avoids adding more difficulty to projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmonahan kmonahan kmonahan approved these changes

@dcmouyard dcmouyard Awaiting requested review from dcmouyard

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coreylafferty @kmonahan