fix(#1328): resolve RenderFlex overflow in AI dialog on Android#1329
Open
AbdelrahmanELBORGY wants to merge 1 commit intofoss42:mainfrom
Open
fix(#1328): resolve RenderFlex overflow in AI dialog on Android#1329AbdelrahmanELBORGY wants to merge 1 commit intofoss42:mainfrom
AbdelrahmanELBORGY wants to merge 1 commit intofoss42:mainfrom
Conversation
|
@AbdelrahmanELBORGY I've just tested this on Android 15 (Redmi) and can confirm that the overflow is resolved. The Row→Column approach works great. Nice catch! |
Contributor
|
@AbdelrahmanELBORGY check #1269 |
Contributor
Author
|
@praaatap yes I have seen that after i have submitted my PR, thanks for pointing out brother |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Root Cause:
The primary crash was caused by a
Rowlayout containing the "Select Model Provider" text and dropdown, which resulted in a horizontalRenderFlexoverflow on mobile screens. Additionally, the main dialogColumnlacked scrolling capabilities, leading to vertical overflow on shorter devices.Fix:
Rowto aColumnto prevent the horizontal RenderFlex crash.SingleChildScrollViewto allow safe vertical scrolling.ADDropdownButtonin a decoratedContainerto provide a standard UI border, making the dropdown visually distinct.Visual Proof:
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
OS on which you have developed and tested the feature?