feat: Add Ctrl+S/Cmd+S keyboard shortcut for save action #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created SaveIntent and SaveAction classes in lib/actions/ - Modified Dashboard to add keyboard shortcut support using Shortcuts and Actions widgets - Added support for Ctrl+S (Windows/Linux) and Cmd+S (macOS) - Reuses existing save logic from save_utils.dart - Only triggers when there are unsaved changes - Prevents multiple simultaneous saves - Added basic tests in test/actions/save_action_test.dart Fixes foss42#475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I've added keyboard shortcut support for the save action as requested in #475 .
Users can now press Ctrl+S (Windows/Linux) or Cmd+S (macOS) to save collections and environments.
Implementation Details
I used Flutter's built-in
ShortcutsandActionswidgets to intercept keyboard events. I wrapped the Dashboard's Scaffold with these widgets to enable global keyboard shortcut support.The save action:
save_utils.dartTesting
I've tested this thoroughly on Windows:
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
I've added basic tests in
test/actions/save_action_test.dartfor the SaveIntent and SaveAction classes, as well as tests to verify the keyboard shortcut registration.OS on which you have developed and tested the feature?
I developed and tested this feature on Windows 11. The implementation uses platform detection (
kIsMacOS) to automatically use the correct modifier key (Ctrl on Windows/Linux, Cmd on macOS).