Skip to content

Fix: Horizontal overflow in Logs toolbar (#984) #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akarshkushwaha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Horizontal overflow in Logs toolbar (#984) #985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 57 additions & 52 deletions lib/screens/terminal/terminal_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,61 +43,66 @@ class _TerminalPageState extends ConsumerState<TerminalPage> {
children: [
Padding(
padding: const EdgeInsets.fromLTRB(12, 8, 12, 8),
child: Row(
children: [
Expanded(
child: SearchField(
controller: _searchCtrl,
hintText: 'Search logs',
onChanged: (_) => setState(() {}),
child: SingleChildScrollView(
scrollDirection: Axis.horizontal,
child: Row(
children: [
SizedBox(
width: 160,
child: SearchField(
controller: _searchCtrl,
hintText: 'Search logs',
onChanged: (_) => setState(() {}),
),
),
const SizedBox(width: 8),
// Filter button
TerminalLevelFilterMenu(
selected: _selectedLevels,
onChanged: (set) => setState(() {
_selectedLevels
..clear()
..addAll(set);
}),
),
),
const SizedBox(width: 8),
// Filter button
TerminalLevelFilterMenu(
selected: _selectedLevels,
onChanged: (set) => setState(() {
_selectedLevels
..clear()
..addAll(set);
}),
),
const SizedBox(width: 4),
Tooltip(
message: 'Show timestamps',
child: Row(
mainAxisSize: MainAxisSize.min,
children: [
Checkbox(
materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
value: _showTimestamps,
onChanged: (v) =>
setState(() => _showTimestamps = v ?? false),
),
const Text('Timestamp', style: TextStyle(fontSize: 12)),
],
const SizedBox(width: 4),
Tooltip(
message: 'Show timestamps',
child: Row(
mainAxisSize: MainAxisSize.min,
children: [
Checkbox(
materialTapTargetSize:
MaterialTapTargetSize.shrinkWrap,
value: _showTimestamps,
onChanged: (v) =>
setState(() => _showTimestamps = v ?? false),
),
const Text('Timestamp', style: TextStyle(fontSize: 12)),
],
),
),
),

const Spacer(),
// Clear button
ADIconButton(
tooltip: 'Clear logs',
icon: Icons.delete_outline,
iconSize: 22,
onPressed: () {
ref.read(terminalStateProvider.notifier).clear();
},
),
const SizedBox(width: 4),
// Copy all button
CopyButton(
showLabel: false,
toCopy: ref
.read(terminalStateProvider.notifier)
.serializeAll(entries: allEntries),
),
],
const SizedBox(width: 24),
// Clear button
ADIconButton(
tooltip: 'Clear logs',
icon: Icons.delete_outline,
iconSize: 22,
onPressed: () {
ref.read(terminalStateProvider.notifier).clear();
},
),
const SizedBox(width: 4),
// Copy all button
CopyButton(
showLabel: false,
toCopy: ref
.read(terminalStateProvider.notifier)
.serializeAll(entries: allEntries),
),
],
),
),
),
const Divider(height: 1),
Expand Down