Skip to content

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Dec 29, 2024

Preparation for #1457

We are exporting other symbols as well and mixing default export
with regular ones is considered bad practice apparently.
This will make typing the arguments a bit easier.
Another long standing bug discovered by TypeScript.
We were missing `id` and others.
Also format the type into multiple lines for legibility.
@jtojnar jtojnar added this to the 2.20 milestone Dec 29, 2024
@netlify
Copy link

netlify bot commented Dec 29, 2024

Deploy Preview for selfoss canceled.

Name Link
🔨 Latest commit e88f0b8
🔍 Latest deploy log https://app.netlify.com/sites/selfoss/deploys/677119b01ca1b0000803222b

@jtojnar jtojnar merged commit e88f0b8 into master Dec 29, 2024
15 checks passed
@jtojnar jtojnar deleted the cleanups branch December 29, 2024 10:06
PhrozenByte added a commit to PhrozenByte/selfoss that referenced this pull request Sep 26, 2025
Fixes 'TypeError: can't access property starred, r is undefined' introduced in 00cf3d6 (fossar#1512).
PhrozenByte added a commit to PhrozenByte/selfoss that referenced this pull request Sep 26, 2025
Fixes 'TypeError: can't access property starred, r is undefined' introduced in 00cf3d6 (fossar#1512).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants