[ANE-2235] Fix pnpm v9 test dependencies

Author: ryanlink

test/Pnpm/PnpmLockSpec.hs

@@ -4,7 +4,8 @@ module Pnpm.PnpmLockSpec (
   spec,
 ) where
 
-import Data.Either (fromRight)
+import Data.ByteString qualified as BS
+import Data.Either (fromRight, isRight)
 import Data.Set qualified as Set
 import Data.String.Conversion (toString)
 import Data.Text (Text)
@@ -23,16 +24,16 @@ import GraphUtil (
 import Graphing (Graphing)
 import Path (Abs, File, Path, mkRelFile, (</>))
 import Path.IO (getCurrentDir)
-import Strategy.Node.Pnpm.PnpmLock (buildGraph)
+import Strategy.Node.Pnpm.PnpmLock (analyze, buildGraph)
 import Test.Hspec (
   Spec,
   describe,
   expectationFailure,
   it,
   runIO,
+  shouldMatchList,
+  shouldSatisfy,
  )
-import Test.Hspec.Core.QuickCheck (shouldSatisfy)
-import Test.Hspec.Expectations (shouldMatchList)
 
 -- | A dependency value used as a default in case of parsing errors in tests
 invalidDependency :: Dependency
@@ -124,24 +125,33 @@ spec = do
 
   -- v9 format
   let pnpmLockV9 = currentDir </> $(mkRelFile "test/Pnpm/testdata/pnpm-lock-v9.yaml")
+  let pnpmLockV9Test = currentDir </> $(mkRelFile "test/Pnpm/testdata/pnpm-lock-v9-test.yaml")
 
   describe "can work with v9.0 format" $ do
-    checkGraph pnpmLockV9 pnpmLockV9GraphSpec
+    describe "with real-world pnpm repo lockfile" $
+      checkGraph pnpmLockV9 pnpmLockV9GraphSpec
+
+    describe "with test dependencies" $
+      checkGraph pnpmLockV9Test pnpmLockV9TestGraphSpec
 
   describe "parsePnpmLock" $ do
-    it "parses v6 lockfile" $ do
-      lockfile <- readFileBS "test/Pnpm/fixtures/pnpm-lock-v6.yaml"
-      let result = parsePnpmLock lockfile
-      result `shouldSatisfy` isRight
-      let Right deps = result
-      deps `shouldMatchList` [colors, mkDevDep "[email protected]", mkDevDep "[email protected]"]
-
-    it "parses v9 lockfile" $ do
-      lockfile <- readFileBS "test/Pnpm/fixtures/pnpm-lock-v9.yaml"
-      let result = parsePnpmLock lockfile
-      result `shouldSatisfy` isRight
-      let Right deps = result
-      deps `shouldMatchList` [colors, mkDevDep "[email protected]", mkDevDep "[email protected]"]
+    currentDir <- runIO getCurrentDir
+    let v6LockfilePath = currentDir </> $(mkRelFile "test/Pnpm/testdata/pnpm-lock-v6.yaml")
+    let v9LockfilePath = currentDir </> $(mkRelFile "test/Pnpm/testdata/pnpm-lock-v9.yaml")
+
+    checkGraph v6LockfilePath $ \graph ->
+      it "parses v6 lockfile" $
+        expectDirect [colors, mkDevDep "[email protected]", mkDevDep "[email protected]"] graph
+
+    checkGraph v9LockfilePath $ \graph ->
+      it "parses v9 lockfile" $
+        expectDirect
+          [ mkProdDep "[email protected]"
+          , mkProdDep "[email protected]"
+          , mkProdDep "[email protected]"
+          , mkProdDep "[email protected]"
+          ]
+          graph
 
 pnpmLockGraphSpec :: Graphing Dependency -> Spec
 pnpmLockGraphSpec graph = do
@@ -441,3 +451,27 @@ pnpmLockV9GraphSpec graph = do
       hasEdge (mkProdDep "@babel/[email protected]") (mkProdDep "@babel/core@^7.0.0")
       hasEdge (mkProdDep "@babel/[email protected]") (mkProdDep "@babel/types@*")
       hasEdge (mkProdDep "@babel/[email protected]") (mkProdDep "@babel/types@*")
+
+pnpmLockV9TestGraphSpec :: Graphing Dependency -> Spec
+pnpmLockV9TestGraphSpec graph = do
+  let hasEdge :: Dependency -> Dependency -> IO ()
+      hasEdge = expectEdge graph
+
+  describe "buildGraph with test dependencies" $ do
+    it "should include git, url and dev dependencies" $ do
+      expectDirect
+        [ colorsTarball
+        , lodash
+        , mkDevDep "[email protected]"
+        ]
+        graph
+
+    it "should include all relevant edges for aws-sdk" $ do
+      hasEdge (mkProdDep "[email protected]") (mkProdDep "[email protected]")
+      hasEdge (mkProdDep "[email protected]") (mkProdDep "[email protected]")
+      hasEdge (mkProdDep "[email protected]") (mkProdDep "[email protected]")
+      hasEdge (mkProdDep "[email protected]") (mkProdDep "[email protected]")
+
+    it "should include all relevant edges for react" $ do
+      hasEdge (mkDevDep "[email protected]") (mkDevDep "[email protected]")
+      hasEdge (mkDevDep "[email protected]") (mkDevDep "[email protected]")