fix: Renaming Homescreen tabs#1428
Conversation
Reviewer's GuideThis PR reorders the Homescreen tabs by swapping the Animation and Transition tabs and refactors their content: AnimationTab now hosts special icon-based animations while TransitionTab displays the basic animation options; comments, imports, and constructors are updated accordingly, and the pubspec.lock file is removed. Class diagram for updated AnimationTab and TransitionTabclassDiagram
class AnimationTab {
+State createState()
// Now displays special icon-based animations
}
class TransitionTab {
+State createState()
// Now displays basic animation options
}
AnimationTab --|> StatefulWidget
TransitionTab --|> StatefulWidget
class AniContainer {
+animation
+icon
+animationName
+index
}
AnimationTab o-- AniContainer
TransitionTab o-- AniContainer
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider refactoring the repeated AniContainer rows into a data-driven builder (e.g. iterate over a list of animation metadata) to reduce duplication and simplify future ordering changes.
- The import of constants.dart in transitiontab.dart isn’t used anymore—removing it will keep dependencies clean.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider refactoring the repeated AniContainer rows into a data-driven builder (e.g. iterate over a list of animation metadata) to reduce duplication and simplify future ordering changes.
- The import of constants.dart in transitiontab.dart isn’t used anymore—removing it will keep dependencies clean.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build StatusBuild successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/17459619474/artifacts/3925447347. ScreenshotsAndroid Screenshots
iPhone Screenshots
iPad Screenshots
|
||||||||||||||||||||||||
-1_home_screen.png?raw=true)
-2_text_badge.png?raw=true){kind=icon}
-3_emoji_badge.png?raw=true){kind=icon}
-4_inverted_emoji_badge.png?raw=true){kind=icon}
-5_saved_badges.png?raw=true)
-6_saved_badges_clicked.png?raw=true)
-7_draw_badge.png?raw=true){kind=icon}
|
hey @hpdang @mariobehling @AsCress need your reviews |
|
I don't have context on this change. If this is intentional, then looks good to me. |
|
Is there an issue linked as to why we need to make this change? Or any context? |
@adityastic yes, it was discussed in meeting as we have added new custom animations and the older animation is renamed as transition so that the correct sequence should be |
mariobehling
left a comment
mariobehling
left a comment
There was a problem hiding this comment.
Please follow best practices: https://blog.fossasia.org/open-source-developer-guide-and-best-practices-at-fossasia/
Add an issue to each PR. If there is no issue open an issue first before you make a PR.
Secondly add screenshots to the PR showing your changes.
mariobehling
left a comment
mariobehling
left a comment
There was a problem hiding this comment.
Please also resolve conflicts.
Co-authored-by: Mario Behling <mb@mariobehling.de>
mariobehling
left a comment
mariobehling
left a comment
There was a problem hiding this comment.
Please address @sourcery-ai comments #1428 (review)
|
@mariobehling i think for this we need to first merge #1412 |
|
This overlapped with another merge that was just done. Please resolve changes. |
|
@mariobehling resolved the conflicts |
6 participants
Fixes #1439
Changes
Changed the ordering of Homescreen tabs
Screenshots / Recordings
Checklist:
constants.dartwithout hard coding any value.Summary by Sourcery
Reorder the Homescreen tabs and swap the content of the Animation and Transition tabs to better distinguish basic and special animations.
Enhancements:
Chores: