fix: Persistent animation text font sizes across tabs #1431
Merged
mariobehling merged 5 commits intofossasia:developmentfrom Sep 11, 2025
Merged
fix: Persistent animation text font sizes across tabs #1431mariobehling merged 5 commits intofossasia:developmentfrom
mariobehling merged 5 commits intofossasia:developmentfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR unifies and persists text font sizes for effect and animation labels by refactoring the Text widgets to use a consistent responsive size, adding overflow constraints where needed, and cleaning up the pubspec.lock file. Class diagram for updated EffectContainer and AniContainer widgetsclassDiagram
class EffectContainer {
+String effectName
}
class _EffectContainerState {
+build()
-Text widget updated:
fontSize: 10.sp
overflow: TextOverflow.ellipsis
maxLines: 1
}
EffectContainer --> _EffectContainerState
class AniContainer {
+String animationName
}
class _AniContainerState {
+build()
-Text widget updated:
fontSize: 10.sp
overflow: TextOverflow.ellipsis
maxLines: 1
}
AniContainer --> _AniContainerState
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- It looks like pubspec.lock was deleted — you probably want to restore it to avoid losing locked dependency versions.
- The repeated TextStyle(fontSize: 10.sp, overflow: ellipsis) could be centralized in a shared constant or theme to reduce duplication.
- Double-check other text widgets or tabs for consistent font sizing to ensure uniform UI across the app.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- It looks like pubspec.lock was deleted — you probably want to restore it to avoid losing locked dependency versions.
- The repeated TextStyle(fontSize: 10.sp, overflow: ellipsis) could be centralized in a shared constant or theme to reduce duplication.
- Double-check other text widgets or tabs for consistent font sizing to ensure uniform UI across the app.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
samruddhi-Rahegaonkar
approved these changes
Aug 27, 2025
Member
|
Please follow best practices. Which issue does this PR resolve? |
mariobehling
requested changes
Sep 1, 2025
Member
mariobehling
left a comment
There was a problem hiding this comment.
Please explain why pubspec lock needs to be deleted.
mariobehling
requested changes
Sep 4, 2025
Member
mariobehling
left a comment
There was a problem hiding this comment.
Please resolve conflicts.
mariobehling
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1440
Changes
Screenshots / Recordings
Checklist:
constants.dartwithout hard coding any value.Summary by Sourcery
Fix persistent animation text font sizes across tabs by standardizing both animation and effect text to 10.sp, adding overflow and line limits to the effect name, and removing the stale pubspec.lock file.
Bug Fixes:
Chores: