-
Notifications
You must be signed in to change notification settings - Fork 246
fix(animation): align Dot-Matrix frame stepping and Snowflake timing;… #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
… rename UI label to 'Dot-Matrix'
Reviewer's GuideUnified animation timing by standardizing one tick == one frame, refactored the Snowflake animation to a single-phase drop algorithm, aligned frame stepping logic in the general Dot-Matrix animation to use modulo operations, and updated the UI label to ‘Dot-Matrix’. Sequence diagram for unified animation frame steppingsequenceDiagram
participant Timer
participant "AniAnimation.processAnimation()"
participant "SnowFlakeAnimation.processAnimation()"
participant Canvas
Timer->>"AniAnimation.processAnimation()": increment animationIndex (one tick)
"AniAnimation.processAnimation()"->>Canvas: update frame using animationIndex % framesCount
Timer->>"SnowFlakeAnimation.processAnimation()": increment animationIndex (one tick)
"SnowFlakeAnimation.processAnimation()"->>Canvas: update frame using animationIndex % totalFrames
Class diagram for updated SnowFlakeAnimation and AniAnimation classesclassDiagram
class SnowFlakeAnimation {
+processAnimation(int badgeHeight, int badgeWidth, int animationIndex, List<List<bool>> processGrid, List<List<bool>> canvas)
}
class AniAnimation {
+processAnimation(int badgeHeight, int badgeWidth, int animationIndex, List<List<bool>> processGrid, List<List<bool>> canvas)
}
class BadgeAnimation
BadgeAnimation <|-- SnowFlakeAnimation
BadgeAnimation <|-- AniAnimation
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… rename UI label to 'Dot-Matrix'
Fixes #
Changes
Screenshots / Recordings
Checklist:
constants.dartwithout hard coding any value.Summary by Sourcery
Standardize animation timing across badge animations and update UI naming
Enhancements: