fix: Add base fallback files for nb and zh by shraavv · Pull Request #1589 · fossasia/badgemagic-app

shraavv · 2026-02-18T13:33:49Z

Fixes #1588

Changes

A base locale fallback file was created for app_nb_NO.arb in l10n directory
app_zh_Hans.arb was renamed to app_zh as simplified chinese is widely used varient

Checklist:

No hard coding: I have used resources from constants.dart without hard coding any value.
No end of file edits: No modifications done at end of resource files.
Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
Code analyzation: My code passes analyzations run in flutter analyze and tests run in flutter test.

sourcery-ai

Sorry @shraavv, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Copilot

Pull request overview

This PR addresses Flutter’s stricter localization generation requirements by adding base fallback locale ARB files for Norwegian Bokmål (nb) and Chinese (zh) so that region/script-specific ARBs (e.g., nb_NO, zh_Hant) have a required base.

Changes:

Added base fallback ARB files: lib/l10n/app_nb.arb and lib/l10n/app_zh.arb.
Regenerated localization outputs (updated app_localizations.dart, added multiple app_localizations_*.dart files, and expanded untranslated.json).
Updated pubspec.lock (dependency resolutions + SDK minimums) and modified macOS plugin registration output.

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
untranslated.json	Regenerated untranslated message report across locales.
pubspec.lock	Dependency resolution and SDK minimum updates.
macos/Flutter/GeneratedPluginRegistrant.swift	Plugin registrant changed (notably removed `path_provider` registration).
lib/l10n/app_zh.arb	Added base `zh` ARB fallback (currently empty).
lib/l10n/app_nb.arb	Added base `nb` ARB fallback (empty).
lib/l10n/app_localizations.dart	Regenerated localization delegate/lookup and supported locales list.
lib/l10n/app_localizations_*.dart	Newly generated per-locale Dart localization implementations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Aryan-Singla · 2026-02-20T11:14:31Z

Hi @shraavv,

I reviewed the PR and noticed that, along with the ARB fallback files, several generated files and platform-specific changes (such as the macOS plugin registrant and pubspec.lock updates) are also included.

Since the issue specifically focuses on adding the base fallback ARB files for nb and zh, do you think we could keep the PR more minimal by limiting it to only the required localization changes?

shraavv · 2026-02-20T11:32:01Z

@Aryan-Singla Thank you for the review! Will update the PR accordingly.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-20T13:37:17Z

+    Locale('de'),
    Locale('en'),
+    Locale('es'),
+    Locale('fr'),
+    Locale('he'),
    Locale('hi'),
-    Locale('it')
+    Locale('id'),
+    Locale('it'),
+    Locale('ja'),
+    Locale('nb'),
+    Locale('nb', 'NO'),
+    Locale('pt'),
+    Locale('pt', 'BR'),
+    Locale('ru'),
+    Locale('uk'),
+    Locale('vi'),
+    Locale('zh'),
+    Locale.fromSubtags(languageCode: 'zh', scriptCode: 'Hant')


All newly added base locale ARB files (app_de.arb, app_es.arb, app_fr.arb, app_he.arb, app_id.arb, app_ja.arb, app_nb.arb, app_pt.arb, app_ru.arb, app_uk.arb, app_vi.arb, app_zh.arb) contain only empty JSON objects. This means all users of these languages will see English text throughout the application.

While creating empty placeholder files may resolve the Flutter localization generation error, it creates a poor user experience. The generated localization classes for all these languages return English strings hardcoded in the generated Dart files.

This raises important questions about the project's localization strategy:

Are these languages supported but not yet translated? If so, this should be clearly documented

Should these languages be removed from the supported locales list until translations are available?

Or should the app gracefully fall back to English with proper indication that the selected language isn't fully supported?

The current approach silently shows English to users who select these languages, which may be confusing. Consider either:

Adding actual translations for these languages

Removing unsupported languages from the supportedLocales list

Adding UI indication when a language has incomplete translations

Copilot · 2026-02-20T13:37:17Z

@@ -0,0 +1 @@
+{}


The base fallback file app_zh.arb contains only an empty JSON object. This results in all Chinese users receiving English text instead of Chinese translations. The generated AppLocalizationsZh class returns hardcoded English strings for all translation keys.

According to the PR description, app_zh_Hans.arb was renamed to app_zh.arb because Simplified Chinese is the widely used variant. However, if app_zh_Hans.arb contained actual Chinese translations before being renamed, those translations should be preserved in this file. If app_zh_Hans.arb was also empty, then this needs to be populated with Simplified Chinese translations to provide a proper user experience for Chinese speakers.

Please ensure this file contains actual Chinese (Simplified) translations, not just an empty object.

Suggested change

{}

{

"@@locale": "zh",

"exampleTranslation": "示例翻译"

}

Copilot · 2026-02-20T13:37:18Z

+class AppLocalizationsZhHant extends AppLocalizationsZh {
+  AppLocalizationsZhHant() : super('zh_Hant');
+}


According to the PR description, "app_zh_Hans.arb was renamed to app_zh" because Simplified Chinese is the widely used variant. However, there's a discrepancy: the file lib/l10n/app_zh_Hant.arb (Traditional Chinese) still exists in the directory, while there's no mention of what happened to app_zh_Hans.arb (Simplified Chinese).

The generated code includes AppLocalizationsZhHant class for Traditional Chinese (lines 558-560), but the base AppLocalizationsZh class uses English strings. This suggests that:

Either app_zh_Hans.arb didn't exist before, or

It was renamed to app_zh.arb but its content was lost in the process

If app_zh_Hans.arb contained Simplified Chinese translations, those translations need to be in app_zh.arb. Please clarify the renaming operation and ensure no translations were lost.

mariobehling

Thanks for the contribution. Please address AI reviews or comment if you think they are not relevant.

shraavv · 2026-04-13T05:36:14Z

@mariobehling I have noticed how most of the locale files have empty braces and therefore followed the same pattern for app_nb.arb and app_zh.arb. I am assuming they are just placeholders for future translations.
Should I keep the empty braces as they are, or update them with the appropriate content?

Copilot

Pull request overview

Copilot reviewed 1 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fix: add generated files in l10n fix: add newline chore(deps): upgrade Flutter to 3.41.6 (fossasia#1634) chore: bump actions/upload-artifact from 5 to 6 in /.github/workflows (fossasia#1545) Co-authored-by: Mario Behling <mb@mariobehling.de> chore: remove unwanted generated files in l10n chore(deps): upgrade Flutter to 3.41.6 (fossasia#1634) chore: bump actions/upload-artifact from 5 to 6 in /.github/workflows (fossasia#1545) Co-authored-by: Mario Behling <mb@mariobehling.de>

Copilot AI review requested due to automatic review settings February 18, 2026 13:33

sourcery-ai bot reviewed Feb 18, 2026

View reviewed changes

Copilot started reviewing on behalf of shraavv February 18, 2026 13:34 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

Comment thread macos/Flutter/GeneratedPluginRegistrant.swift

shraavv force-pushed the 1588-fix-arb-issue branch from c053203 to 9d1bdb5 Compare February 20, 2026 13:27

shraavv requested a review from Copilot February 20, 2026 13:28

Copilot started reviewing on behalf of shraavv February 20, 2026 13:29 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

Comment thread lib/l10n/app_nb.arb Outdated

Comment thread lib/l10n/app_zh.arb

shraavv force-pushed the 1588-fix-arb-issue branch from 9d1bdb5 to d0ef743 Compare February 20, 2026 13:31

Copilot AI review requested due to automatic review settings February 20, 2026 13:33

shraavv force-pushed the 1588-fix-arb-issue branch from 826f694 to 38cb96e Compare February 20, 2026 13:33

Copilot started reviewing on behalf of shraavv February 20, 2026 13:33 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

samruddhi-Rahegaonkar mentioned this pull request Mar 3, 2026

fix: Eraser works correctly when shape tool is selected in Draw Badge #1598

Open

4 tasks

mariobehling requested changes Apr 13, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings April 14, 2026 12:28

shraavv force-pushed the 1588-fix-arb-issue branch from 0ceeb8e to ef4e064 Compare April 14, 2026 12:28

Copilot started reviewing on behalf of shraavv April 14, 2026 12:29 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

shraavv force-pushed the 1588-fix-arb-issue branch from de26bc5 to 747e0be Compare April 14, 2026 12:38

-{}
+{
+  "@@locale": "zh",
+  "exampleTranslation": "示例翻译"
+}

Conversation

shraavv commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Aryan-Singla commented Feb 20, 2026

Uh oh!

shraavv commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

mariobehling left a comment

Choose a reason for hiding this comment

Uh oh!

shraavv commented Apr 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shraavv commented Feb 18, 2026 •

edited

Loading