Skip to content

fix: fixed preview same as the badge result#1795

Open
ctrlVnt wants to merge 4 commits into
fossasia:developmentfrom
ctrlVnt:resize-screen-badge
Open

fix: fixed preview same as the badge result#1795
ctrlVnt wants to merge 4 commits into
fossasia:developmentfrom
ctrlVnt:resize-screen-badge

Conversation

@ctrlVnt

@ctrlVnt ctrlVnt commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Partial fixes #1775

Changes

I tried to switch of one column the transfer but I didn't manage to do it. I realized that fixed preview was different from result, so I decided to adapt the preview. Even if it doesn't fix completely the problem now user knows what to expect.

Screenshots / Recordings

Screenshot_20260703-134329 Screenshot_20260703-134342

Checklist:

  • No hard coding: I have used resources from constants.dart without hard coding any value.
  • No end of file edits: No modifications done at end of resource files.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • Code analyzation: My code passes analyzations run in flutter analyze and tests run in flutter test.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @ctrlVnt, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@ctrlVnt ctrlVnt requested review from bhavjsh and rahul31124 July 3, 2026 11:44
@ctrlVnt ctrlVnt changed the title fixed the fixed preview fix: fixed preview same as the badge result Jul 3, 2026
@ctrlVnt

ctrlVnt commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

1775 - Partially compliant

Compliant requirements:

  • Ensure that the code is properly formatted and follows best practices
  • Run code analysis and tests to ensure that the code is correct and works as expected

Non-compliant requirements:

  • Fix the issue where the preview is different from the badge result (although the PR description mentions that it doesn't fix the problem completely, it does adapt the preview)

Requires further human verification:

  • Verify that the adapted preview is correct and meets the requirements
⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Issue

The adapted preview may not be correct and may not meet the requirements. The code changes in this PR only adapt the preview, but do not fix the underlying issue. This may lead to incorrect results being displayed to the user.

int newGridHeight = processGrid.length;
int newGridWidth = processGrid[0].length;
const int startCol = 0;

for (int i = 0; i < badgeHeight; i++) {
  for (int j = 0; j < badgeWidth; j++) {
    bool isNewGridCell = i < newGridHeight && (startCol + j) < newGridWidth;
    bool animationCondition =
        (isNewGridCell && processGrid[i][startCol + j]);

    canvas[i][j] = animationCondition;
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug drawing a badge

1 participant