feat: allow skipping splash screen with 0ms duration (#115)

[P-rth]

Addresses #115 by allowing users to skip the splash screen.

Previously, SPLASH_MIN_SPEED_T imposed a minimum duration. By setting this to 0, users can now skip the splash screen.

Changes

Updated SPLASH_MIN_SPEED_T to 0 in src/config.h

Testing

Verified on local build using the MRS toolchain.

Closes #115

Summary by Sourcery

New Features:

• Enable configuring the splash screen with a 0ms minimum duration to skip it entirely.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR makes the splash screen skippable by setting the configured minimum splash duration to 0ms so that the splash display is no longer enforced.

Flow diagram for app startup with configurable splash minimum duration

flowchart TD
  AppStart[App start]
  CheckMinDuration[Check SPLASH_MIN_SPEED_T]
  ShowSplash[Render splash screen]
  WaitMinDuration[Wait SPLASH_MIN_SPEED_T milliseconds]
  MainUI[Show main UI]

  AppStart --> CheckMinDuration
  CheckMinDuration -->|SPLASH_MIN_SPEED_T > 0| ShowSplash
  ShowSplash --> WaitMinDuration
  WaitMinDuration --> MainUI
  CheckMinDuration -->|SPLASH_MIN_SPEED_T = 0| MainUI

Loading

File-Level Changes

Change	Details	Files
Allow splash screen to be skipped by removing the enforced minimum display duration.	Changed the SPLASH_MIN_SPEED_T constant value from 10ms to 0ms to eliminate the minimum splash duration constraint. Left splash size configuration and other related constants unchanged.	src/config.h

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#115	Allow users to completely skip the splash screen by permitting a splash display time of 0 ms (removing the enforced positive minimum duration).	✅

Possibly linked issues

• Allow users to skip splash screen by setting display time to zero ms #115: PR changes SPLASH_MIN_SPEED_T to 0ms, exactly implementing the issue’s request to skip the splash screen.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[P-rth]

Looking a bit more at the documentation, I see that the delay is explicitly mentioned:
in BadgeBLE.md

Parameters:

    Adjust splash screen speed: [0x00, speed_ms]. speed_ms (16-bit) is the delay of each frame in milliseconds and must not be lower than 10 ms.

I cant seem to find a reason for adding "must not be lower than 10ms", Though I don't have the hardware currently to test it on a real device.

maybe im missing something?