-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automatically include version numbers #53
Conversation
b0ed767
to
e7cfe5b
Compare
Reviewer's Guide by SourceryThis pull request implements automatic embedding of version numbers in the firmware. It retrieves the version from git tags and applies it to BLE's Device Info, USB's Serial Number, and the charging animation display. The changes involve modifications to several files to incorporate and display the version information. Class diagram for version embedding changesclassDiagram
class USBDevice {
+uint16_t[] product_info
+uint16_t[] serial_number
+void desc_dev(USB_SETUP_REQ *request)
}
class BLEDeviceInfo {
+uint8_t[] systemId_val
+uint16_t systemId_UUID
+uint8_t[] modelNumber_val
+uint16_t modelNumber_UUID
+uint16_t serialNumber_UUID
+uint8_t[] serialNumber_val
+uint16_t firmwareRev_UUID
+uint8_t[] firmwareRev_val
+uint16_t hardwareRev_UUID
+uint8_t[] hardwareRev_val
+uint16_t softwareRev_UUID
+uint8_t[] softwareRev_val
}
class Makefile {
+string VERSION_ABBR
+string VERSION
}
USBDevice --> Makefile : uses
BLEDeviceInfo --> Makefile : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kienvo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Resolves #44
Changes:
Summary by Sourcery
Automatically embed version numbers from git into various components of the system, including BLE Device Info, USB Serial Number, and charging animation. Enhance the build process to retrieve and define version information from git tags. Update the CI workflow to support versioning by fetching tags.
New Features:
Enhancements:
CI: