fix-for-documentation-to-match-latest-development#71
fix-for-documentation-to-match-latest-development#71Manik-Khajuria-5 wants to merge 3 commits intofossasia:developmentfrom
Conversation
✅ Deploy Preview for eventyay-checkin ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDocumentation for the check-in and exhibitor workflows has been updated to better match the current UI/wording, improving clarity and consistency of instructions. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 3 issues, and left some high level feedback:
- The terminology for the flow varies between
CheckIn,checkin, andcheck-in; consider standardizing this throughout the docs for consistency. - In the updated step descriptions, review capitalization of common nouns like 'server' and 'login page' to align with the rest of the documentation style.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The terminology for the flow varies between `CheckIn`, `checkin`, and `check-in`; consider standardizing this throughout the docs for consistency.
- In the updated step descriptions, review capitalization of common nouns like 'server' and 'login page' to align with the rest of the documentation style.
## Individual Comments
### Comment 1
<location path="docs/checkin.md" line_range="3" />
<code_context>
# CheckIn Workflow
-**Step 1:** In the Login page Select Server and role `I am a Checkin-Staff`
+**Step 1:** In the Login page, select a Server and click `I am a Checkin Staff`
<img src="./images/login.png" alt="Login Page">
</code_context>
<issue_to_address>
**suggestion (typo):** Consider improving the phrasing of "In the Login page" and verifying the spelling of "Checkin Staff".
You could update this line to something like: `**Step 1:** On the login page, select a server and click "I am a check-in staff"`. Also, please confirm the button label in the UI uses the same spelling and hyphenation as in the docs.
Suggested implementation:
```
**Step 1:** On the login page, select a server and click `I am a check-in staff`
```
1. Verify the actual label text of the button in the UI. If it differs (e.g., "I am a Checkin-Staff", "I am a Check-in Staff", etc.), update either the UI or this doc so they match exactly.
2. Search the rest of the docs for "Checkin Staff" / "Check-in staff" and standardize the spelling and hyphenation.
</issue_to_address>
### Comment 2
<location path="docs/checkin.md" line_range="15" />
<code_context>
<img src="./images/checkin.png" alt="Checkin">
-**Step 5:** Once a check-in is done a popup will appear to show the details of the checked-in attendee, with the option to generate a badge
+**Step 5:** Once a checkin is done a popup will appear to show the details of the checked-in attendee, with the option to generate a badge
The Badge can be generated by clicking the `Generate Badge` button
<img src="./images/info.png" alt="Attendee Info">
</code_context>
<issue_to_address>
**suggestion (typo):** Add a comma after the introductory clause and hyphenate "check-in" for consistency.
You could revise this to: "Once a check-in is done, a popup will appear to show the details of the checked-in attendee, with the option to generate a badge."
```suggestion
**Step 5:** Once a check-in is done, a popup will appear to show the details of the checked-in attendee, with the option to generate a badge
```
</issue_to_address>
### Comment 3
<location path="docs/exhibitor.md" line_range="3" />
<code_context>
# Exhibitor Workflow
-**Step 1:** In the Login page Select Server and role `I am a Exhibitor`
+**Step 1:** In the Login page, select a Server and click `I am an Exhibitor`
<img src="./images/login.png" alt="Login Page">
</code_context>
<issue_to_address>
**suggestion (typo):** Consider rephrasing "In the Login page" to the more idiomatic "On the login page".
You could rewrite this as: "On the login page, select a server and click `I am an Exhibitor`." This uses the more natural preposition "on" and standard capitalization unless those terms match specific UI labels.
```suggestion
**Step 1:** On the login page, select a server and click `I am an Exhibitor`.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| # CheckIn Workflow | ||
|
|
||
| **Step 1:** In the Login page Select Server and role `I am a Checkin-Staff` | ||
| **Step 1:** In the Login page, select a Server and click `I am a Checkin Staff` |
There was a problem hiding this comment.
suggestion (typo): Consider improving the phrasing of "In the Login page" and verifying the spelling of "Checkin Staff".
You could update this line to something like: **Step 1:** On the login page, select a server and click "I am a check-in staff". Also, please confirm the button label in the UI uses the same spelling and hyphenation as in the docs.
Suggested implementation:
**Step 1:** On the login page, select a server and click `I am a check-in staff`
- Verify the actual label text of the button in the UI. If it differs (e.g., "I am a Checkin-Staff", "I am a Check-in Staff", etc.), update either the UI or this doc so they match exactly.
- Search the rest of the docs for "Checkin Staff" / "Check-in staff" and standardize the spelling and hyphenation.
|
@mariobehling Hi , I wanted clarification how do qr based device registration in eventyay Can u please help me to figure it out ? |
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Summary
Implemented the documentation part for issue #17.
What is done
Pending / Blockers
What I have tried
Request
Next Steps
Additional Context
This PR is opened to share progress and get early feedback.
Summary by Sourcery
Update user-facing documentation to clarify check-in and exhibitor login workflows.
Documentation: