Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync commits from upstream #2

Merged
merged 14 commits into from
Oct 29, 2024
Merged

Conversation

lcduong
Copy link

@lcduong lcduong commented Oct 23, 2024

Commit hash Description
c7e0bce675ae09d84f3e279f0e20442a391de23b Release v1.6.0
0274dab0431ca7e3f618885eabb8f37d565fea4c Update translations
9e8980bca8584f79b51536428ee3fa129c26cc72 Improve error display
adf6c86fe01fb579889a80dc3340a4fab86843f3 Render form errors correctly
c36904f27481e8533514e885cc0086488c7e0c01 Remove django-bootstrap4
6ee5914d74ca2673a2dae57a8f3ae8302f811a2d Optimise imports
e6fbd595c1deb2d08b8eb5890a90789cfb7f1da3 Fix the last hidden button
34857d41c135f6160d383c7abe3fd7aeac68b12c Fix missing create button
f69f3d1484c769036a1f12680d28e674a6b93476 Fix hidden buttons
a374c3e56fb9376148bafea68f35d0171c12350e Remove logs from pages
abea68fd937720108b40f9f8bae71183023bad0e Fix page titles again
7de02b4bd147950d7a0386a969b82de2671a3337 Fix page titles
fd56614c8ad905bb8a0aa8e6b7a5397ea102b9a8 Make template format consistent
95a2892ac91f8b05bd56088173d01e39aa8ab024 Release v1.5.0

Summary by Sourcery

Sync with upstream to incorporate changes including a new release version 1.6.0, bug fixes for button visibility and page titles, and enhancements in error display and template consistency.

New Features:

  • Introduce a new version 1.6.0 with updated features and improvements.

Bug Fixes:

  • Fix the display of hidden buttons and missing create button.
  • Correct the rendering of form errors and page titles.

Enhancements:

  • Improve error display and optimize import statements.
  • Make template format consistent across pages.

Copy link

sourcery-ai bot commented Oct 23, 2024

Reviewer's Guide by Sourcery

This pull request syncs commits from upstream, updating the pretalx_pages plugin to version 1.6.0. The changes include template updates, removal of django-bootstrap4 dependency, improvements in error handling, and various UI enhancements.

Class diagram for template changes in pretalx_pages

classDiagram
    class FormTemplate {
        -bootstrap4
        +extra_title
        +form_errors
        +as_field_group
    }
    class ShowTemplate {
        +extra_title
    }
    class DeleteTemplate {
        +extra_title
    }
    class IndexTemplate {
        +extra_title
        +btn-primary
        +btn-info
        +btn-success
    }
    FormTemplate --> ShowTemplate
    FormTemplate --> DeleteTemplate
    FormTemplate --> IndexTemplate
    note for FormTemplate "Removed bootstrap4 and added extra_title, form_errors, as_field_group"
    note for IndexTemplate "Updated button classes to btn-primary, btn-info, btn-success"
Loading

File-Level Changes

Change Details Files
Update template structure and styling
  • Replace bootstrap4 form rendering with custom form rendering
  • Update block structure in templates
  • Improve HTML formatting and indentation
  • Update CSS classes for consistency and better styling
pretalx_pages/templates/pretalx_pages/form.html
pretalx_pages/templates/pretalx_pages/show.html
pretalx_pages/templates/pretalx_pages/delete.html
pretalx_pages/templates/pretalx_pages/index.html
Improve error handling and display
  • Add import for rich text processing in views.py
  • Update context data generation for page rendering
pretalx_pages/views.py
Update version number
  • Bump version from 1.4.0 to 1.6.0
pretalx_pages/__init__.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider implementing more comprehensive testing to catch regression issues earlier, particularly for UI elements like buttons and page titles.
  • For significant version bumps (e.g., 1.4.0 to 1.6.0), it would be helpful to include more detailed release notes or a changelog to highlight the major changes and new features.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mariobehling mariobehling merged commit e716d69 into fossasia:main Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants