-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(development): deploy Sphinx Documentation automatically to gh-pages using GitHub Actions #260
base: development
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request automates the deployment of Sphinx documentation to GitHub Pages using GitHub Actions. It addresses issue #256 by setting up a workflow that deploys the documentation on every push to the "deployment" branch. Sequence diagram for automated Sphinx documentation deploymentsequenceDiagram
participant D as Developer
participant GH as GitHub Repository
participant GA as GitHub Actions
participant GP as GitHub Pages
D->>GH: Push changes to deployment branch
GH->>GA: Trigger workflow
GA->>GA: Check out repository
GA->>GA: Set up Python
GA->>GA: Install dependencies
GA->>GA: Build Sphinx documentation
GA->>GP: Deploy to gh-pages branch
GP->>GP: Update documentation site
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @r3yc0n1c - I've reviewed your changes - here's some feedback:
Overall Comments:
- The workflow is configured to run on the 'deployment' branch - consider targeting your default branch (usually 'main' or 'master') instead, unless there's a specific reason for using a separate deployment branch.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @r3yc0n1c Thanks for the PR. Please check why the Build Packaging checks are failing. They work before this PR.
Fixes issue #256. It does so by automating the deployment of Sphinx documentation (development) to the gh-pages branch using GitHub Actions. With this workflow, every update to the documentation triggers a deployment, ensuring that the latest changes are always reflected on GitHub Pages.
How has this been tested?
gh-pages
branch.Checklist
etalk.eventyay.com
Summary by Sourcery
Set up a GitHub Actions workflow to automatically deploy the Sphinx documentation to GitHub Pages on every push to the "deployment" branch.
CI:
Documentation: