Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(development): deploy Sphinx Documentation automatically to gh-pages using GitHub Actions #260

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

r3yc0n1c
Copy link

@r3yc0n1c r3yc0n1c commented Jan 16, 2025

Fixes issue #256. It does so by automating the deployment of Sphinx documentation (development) to the gh-pages branch using GitHub Actions. With this workflow, every update to the documentation triggers a deployment, ensuring that the latest changes are always reflected on GitHub Pages.

How has this been tested?

  • Verified that the GitHub Actions workflow runs without errors and deploys the documentation to the gh-pages branch.
  • Checked that the generated documentation appears correctly on GitHub Pages.
  • Verified that the deployment works with updates to the documentation.

image

Checklist

  • Prepare Your Sphinx Documentation
  • Create the gh-pages Branch
  • Configure Automated Deployment via GitHub Actions
  • Add the Custom Subdomain
  • Configure DNS to point to etalk.eventyay.com
  • Verify the Deployment

Summary by Sourcery

Set up a GitHub Actions workflow to automatically deploy the Sphinx documentation to GitHub Pages on every push to the "deployment" branch.

CI:

  • Add a GitHub Actions workflow to deploy the Sphinx documentation to GitHub Pages.

Documentation:

  • Deploy the generated documentation to GitHub Pages, ensuring the latest documentation is always available.

Copy link

sourcery-ai bot commented Jan 16, 2025

Reviewer's Guide by Sourcery

This pull request automates the deployment of Sphinx documentation to GitHub Pages using GitHub Actions. It addresses issue #256 by setting up a workflow that deploys the documentation on every push to the "deployment" branch.

Sequence diagram for automated Sphinx documentation deployment

sequenceDiagram
    participant D as Developer
    participant GH as GitHub Repository
    participant GA as GitHub Actions
    participant GP as GitHub Pages

    D->>GH: Push changes to deployment branch
    GH->>GA: Trigger workflow
    GA->>GA: Check out repository
    GA->>GA: Set up Python
    GA->>GA: Install dependencies
    GA->>GA: Build Sphinx documentation
    GA->>GP: Deploy to gh-pages branch
    GP->>GP: Update documentation site
Loading

File-Level Changes

Change Details Files
Set up a GitHub Actions workflow to automatically deploy the documentation.
  • Created a new workflow file named deploy.yml.
  • Configured the workflow to trigger on pushes to the deployment branch.
  • Added steps to install dependencies, build the documentation using make html, and deploy it to gh-pages using peaceiris/actions-gh-pages@v3.
.github/workflows/deploy.yml
Added a CNAME file.
  • Created a CNAME file, likely to configure a custom domain for the documentation.
CNAME

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @r3yc0n1c - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The workflow is configured to run on the 'deployment' branch - consider targeting your default branch (usually 'main' or 'master') instead, unless there's a specific reason for using a separate deployment branch.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @r3yc0n1c Thanks for the PR. Please check why the Build Packaging checks are failing. They work before this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants