-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt uv as Python package manager #311
Adopt uv as Python package manager #311
Conversation
Reviewer's Guide by SourceryThis pull request migrates the project from pip to uv for Python package management. It includes changes to pyproject.toml to define dependency groups, updates to Dockerfile and GitHub Actions workflows to use uv commands, and the addition of a uv.lock file. The change also refactors the dependency management in Updated class diagram for pyproject.toml dependenciesclassDiagram
class pyproject.toml {
-dependencies: list
-optional-dependencies: dict
+project.urls: dict
+dependency-groups: dict
+tool.uv: dict
}
note for pyproject.toml "Refactored dependencies and added uv configuration"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hongquan - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding
uv generate-lockfile
to your CI to keep the lockfile up to date. - It looks like you've removed the
tool.setuptools.dynamic
section, but it's still needed to dynamically set the version.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unrelated changes, it is puzzling, at makes it MUCH harder to revert in case we need to revert it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although there are still some whitespace related changes in pyproject.toml and some others.
But that is fine somehow.
Fixes #301
How has this been tested?
Checklist