Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove settings #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

HungNgien
Copy link
Collaborator

@HungNgien HungNgien commented Jan 15, 2025

Remove key settings as they are already configured in the global admin of Tickets.

Summary by Sourcery

Chores:

  • Remove now-redundant Stripe Connect settings from eventyay_stripe.

Summary by Sourcery

Chores:

  • Remove Stripe Connect settings from eventyay_stripe as they are now configured in the global admin.

Copy link

sourcery-ai bot commented Jan 15, 2025

Reviewer's Guide by Sourcery

This pull request removes the Stripe Connect settings from the eventyay_stripe plugin, as these settings are now configured in the global admin of Tickets.

Class diagram showing removed Stripe Connect settings fields

classDiagram
    class StripeSettings {
        +payment_stripe_connect_client_id
        -payment_stripe_connect_secret_key [REMOVED]
        -payment_stripe_connect_publishable_key [REMOVED]
        -payment_stripe_connect_test_secret_key [REMOVED]
        -payment_stripe_connect_test_publishable_key [REMOVED]
        +payment_stripe_connect_app_fee_percent
    }
    note for StripeSettings "Stripe Connect settings moved to global admin"
Loading

File-Level Changes

Change Details Files
Removed Stripe Connect settings fields
  • Removed payment_stripe_connect_secret_key field.
  • Removed payment_stripe_connect_publishable_key field.
  • Removed payment_stripe_connect_test_secret_key field.
  • Removed payment_stripe_connect_test_publishable_key field.
eventyay_stripe/signals.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@HungNgien HungNgien marked this pull request as ready for review January 16, 2025 07:28
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @HungNgien - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant