-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public key and secret key of Stripe in admin settings page #509
base: development
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request adds fields for Stripe keys in the global settings admin page, enabling the storage of organizer billing information upon completion. Class diagram for Stripe key validation and settings formclassDiagram
class GlobalSettingsForm {
+__init__(*args, **kwargs)
}
class StripeKeyValidator {
-_prefixes: List[str]
+__init__(prefix: Union[str, List[str]])
+__call__(value: str)
}
class SecretKeySettingsField {
}
GlobalSettingsForm --> StripeKeyValidator : uses
GlobalSettingsForm --> SecretKeySettingsField : uses
note for GlobalSettingsForm "Added new Stripe Connect
key fields with validators"
note for StripeKeyValidator "New validator class for
Stripe API key format"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HungNgien - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…/eventyay-tickets into stripe_global_settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HungNgien - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description: add fields in the global settings to input Stripe keys, allowing the billing information of organizers to be saved when the fields are filled.
This PR resolves #485
Summary by Sourcery
New Features: