Add automatic builds on merged PRs#15
Conversation
Reviewer's Guide by SourceryThis pull request introduces automated builds and CI/CD pipelines for Android and iOS platforms using GitHub Actions. It includes workflows for pull request builds, separate workflows for Android, iOS, and common build checks, and steps for code formatting, linting, and testing. Additionally, it updates the pubspec.yaml file to specify Flutter and Dart SDK versions, and refactors code formatting across multiple files. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @kienvo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using environment variables for configuration instead of hardcoding values.
- The commit history will be cleaner if you squash commits before merging.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Still need to test signing and pushing app in open testing track. I have no idea how it going, @mariobehling @adityastic please continue this work. Edit: And also the iOS build. |
mariobehling
left a comment
There was a problem hiding this comment.
Merging this as work partly done. Thank you
|
@kienvo Please follow up on this. This is only partly done. The automatic builds do not work yet. |
Resolves #2
Changes:
Summary by Sourcery
Set up continuous integration and automatic builds for the Magic Epaper app on both Android and iOS platforms
Enhancements:
Build:
CI:
Chores: