Fix Android build config for flutter_nfc_kit support by Swastik-K-Sahu · Pull Request #20 · fossasia/magic-epaper-app

Swastik-K-Sahu · 2025-04-16T09:45:45Z

Fixes #16
Updates the Android build setup to meet the requirements of the flutter_nfc_kit plugin.

✅ Changes

Set Java Version to 17
Verify minSdk >= 26
Using Gradle 8.9 with AGP 8.7.0
Add android.permission.NFC in AndroidManifest.xml
Set jvmTarget 17 in build.gradle
Set ndkVersion to 27.0.12077973

Summary by Sourcery

Update Android build configuration to support flutter_nfc_kit plugin and improve build compatibility

New Features:

Add NFC permission and feature support in AndroidManifest.xml

Enhancements:

Modify Android build configuration to meet flutter_nfc_kit plugin requirements

Build:

Upgrade Gradle to version 8.9 and Android Gradle Plugin to version 8.7.0
Set Java and Kotlin compilation target to Java 17
Update NDK version to 27.0.12077973

sourcery-ai · 2025-04-16T09:45:49Z

Reviewer's Guide by Sourcery

This pull request updates the Android build configuration to ensure compatibility with the flutter_nfc_kit plugin. The changes include updates to the Java version, Gradle version, AGP version, minSdk version, addition of NFC permissions, setting the jvmTarget, and setting the NDK version.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Updated the Gradle and AGP versions.	Updated the Gradle distribution URL to version 8.9. Updated the Android Gradle Plugin version to 8.7.0.	`android/gradle/wrapper/gradle-wrapper.properties` `android/settings.gradle`
Configured Java version to 17.	Set sourceCompatibility to Java 17. Set targetCompatibility to Java 17. Set jvmTarget to Java 17.	`android/app/build.gradle` `android/build.gradle`
Added NFC permissions to the Android manifest.	Added the `android.permission.NFC` permission. Added the `android.hardware.nfc` feature with `required=false`.	`android/app/src/main/AndroidManifest.xml`
Set NDK version.	Set `ndkVersion` to `27.0.12077973` in `gradle.properties`. Referenced `ndkVersion` from `gradle.properties` in `app/build.gradle`.	`android/app/build.gradle` `android/gradle.properties`

Assessment against linked issues

Issue	Objective	Addressed
#16	Set Java version to 17 and appropriate jvmTarget in build.gradle.	✅
#16	Use Gradle version 8.9 and Android Gradle Plugin version 8.7.	✅
#16	Add NFC permission in AndroidManifest.xml.	✅

Possibly linked issues

Update android configuration for flutter_nfc_kit compatibility #16: The PR addresses all the requirements outlined in the issue by updating Java, Gradle, AGP versions, and adding NFC permissions.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @Swastik-K-Sahu - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider adding a comment explaining why the NDK version is being explicitly set.
It might be good to add a brief explanation in the PR description about why these changes are needed for flutter_nfc_kit support.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

Swastik-K-Sahu · 2025-04-16T17:10:43Z

@mariobehling @kienvo could you please review this?

…-app

AsCress

@Swastik-K-Sahu What was the reason we required these changes again ? Was the build for flutter_nfc_kit failing ?
Also, please have a look at the failing Android build pipeline in the PR, looks like some compatibility issues.

AsCress · 2025-04-29T02:30:11Z

    namespace = "org.fossasia.magic_epaper_app"
    compileSdk = flutter.compileSdkVersion
-    ndkVersion = flutter.ndkVersion
+    ndkVersion = project.properties['android.ndkVersion']


Why do we need this ?

The ndkVersion was not getting updated on my local. It was being set to v26, but the minimum supported for some dependencies were v27.

AsCress · 2025-04-29T02:30:56Z

 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-all.zip


Such updates can usually be handled by dependabot. But till we set up that, this is fine.

AsCress · 2025-04-29T02:31:39Z

 org.gradle.jvmargs=-Xmx4G -XX:MaxMetaspaceSize=2G -XX:+HeapDumpOnOutOfMemoryError
 android.useAndroidX=true
 android.enableJetifier=true
+android.ndkVersion=27.0.12077973


Wouldn't this cause compatibility issues when we upgrade to higher versions of flutter ?

Yes, I got that. I can remove this hardcoded version of ndk and let flutter choose the required ndkVersion.

Swastik-K-Sahu · 2025-04-29T10:33:10Z

@Swastik-K-Sahu What was the reason we required these changes again ? Was the build for flutter_nfc_kit failing ? Also, please have a look at the failing Android build pipeline in the PR, looks like some compatibility issues.

Yes the build for flutter_nfc_kit was failing due to compatibility issues just like there is problem for app_settings. I referred to the NFC Readme and updated the minimum requirements.

Swastik-K-Sahu · 2025-04-29T11:20:30Z

@AsCress I have remove the hardcoded ndkVersion. Now can you check the android build in the pipeline?

AsCress · 2025-04-29T11:27:16Z

@mariobehling Could you please approve the workflows for this pull request ?

mariobehling · 2025-06-23T16:32:44Z

Closing it as the project has progressed in the meantime. Thank you!

chore: configure Gradle and AGP versions to support flutter_nfc_kit

3083a51

sourcery-ai Bot reviewed Apr 16, 2025

View reviewed changes

mariobehling requested review from AsCress and kienvo April 26, 2025 08:19

chore: configure Gradle and AGP versions to support flutter_nfc_kit

49bed08

Swastik-K-Sahu force-pushed the main branch from 3083a51 to 49bed08 Compare April 27, 2025 13:35

Merge branch 'main' of https://github.com/Swastik-K-Sahu/magic-epaper…

bfe22da

…-app

AsCress reviewed Apr 29, 2025

View reviewed changes

Remove hardcoded ndkVersion

2ab2ac1

github-actions Bot added a commit that referenced this pull request Jun 23, 2025

[Unsigned APK] v0.8.1 (#20)

d890d38

mariobehling closed this Jun 23, 2025

Conversation

Swastik-K-Sahu commented Apr 16, 2025 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Changes

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Swastik-K-Sahu commented Apr 16, 2025

Uh oh!

AsCress left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AsCress Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

Swastik-K-Sahu Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

AsCress Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

Swastik-K-Sahu Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

AsCress Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

Swastik-K-Sahu Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

Swastik-K-Sahu commented Apr 29, 2025

Uh oh!

Swastik-K-Sahu commented Apr 29, 2025

Uh oh!

AsCress commented Apr 29, 2025

Uh oh!

mariobehling commented Jun 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Swastik-K-Sahu commented Apr 16, 2025 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented Apr 16, 2025 •

edited

Loading

AsCress left a comment •

edited

Loading