fix: IOS build error due to flutter_nfc_kit issue fixes.#25
Merged
mariobehling merged 1 commit intofossasia:mainfrom Apr 26, 2025
Merged
fix: IOS build error due to flutter_nfc_kit issue fixes.#25mariobehling merged 1 commit intofossasia:mainfrom
mariobehling merged 1 commit intofossasia:mainfrom
Conversation
Contributor
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @Dhruv1797 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment in the Podfile explaining why the platform version is set to 13.0.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
@AsCress @mariobehling @kienvo ✅All 3 CI checks have now passed successfully: Please review it once when you get a chance 🙏 |
AsCress
approved these changes
Apr 23, 2025
Collaborator
AsCress
left a comment
There was a problem hiding this comment.
@Dhruv1797 LGTM ! Nice work there !
Contributor
Author
Collaborator
|
@mariobehling Good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the ios build preview:

Summary by Sourcery
Configure iOS deployment target to resolve build issues with flutter_nfc_kit plugin
Bug Fixes:
Build: