Skip to content

WIP: chore: upload unsigned apk to app branch#30

Closed
kienvo wants to merge 1 commit intofossasia:mainfrom
kienvo:upload-apk-on-push
Closed

WIP: chore: upload unsigned apk to app branch#30
kienvo wants to merge 1 commit intofossasia:mainfrom
kienvo:upload-apk-on-push

Conversation

@kienvo
Copy link
Copy Markdown
Member

@kienvo kienvo commented May 5, 2025

Fix #2

Changes: upload unsigned APKs

Summary by Sourcery

Remove signing and deployment-specific steps from the GitHub Actions workflow to upload unsigned APKs to the app branch

CI:

  • Comment out repository-specific conditions for APK and TestFlight uploads
  • Remove build key preparation steps for Android and iOS

Chores:

  • Remove signing-related steps for Android and iOS builds
  • Modify workflow to upload unsigned APKs

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 5, 2025

Reviewer's Guide

The GitHub Actions workflow (push.yml) was modified to remove steps related to signing and provisioning for both Android and iOS builds. This results in an unsigned Android APK being uploaded to the apk branch and disables the automated deployment steps to Google Play testing tracks and TestFlight.

Flow diagram comparing previous and updated Android build process

flowchart TD
    subgraph Previous Android Build Process
        A[Checkout Code] --> B(Prepare Build Keys);
        B --> C{Android Workflow Action w/ Signing Keys};
        C --> D[Upload Signed APK/AAB];
        D --> E[Push to Google Play Testing Track];
    end

    subgraph Updated Android Build Process
        F[Checkout Code] --> G{Android Workflow Action w/o Signing Keys};
        G --> H[Upload Unsigned APK/AAB];
        H --> I((Push to Google Play Testing Track - Disabled));
    end
Loading

Flow diagram comparing previous and updated iOS build process

flowchart TD
    subgraph Previous iOS Build Process
        A[Checkout Code] --> B(Prepare Build Keys);
        B --> C(Setup Certs w/ Fastlane);
        C --> D{iOS Workflow Action};
        D --> E[Push to TestFlight];
    end

    subgraph Updated iOS Build Process
        F[Checkout Code] --> G{iOS Workflow Action};
        G --> H((Push to TestFlight - Disabled));
    end
Loading

File-Level Changes

Change Details Files
Removed Android build signing process.
  • Removed the Android key preparation step.
  • Removed signing secrets (STORE_PASS, ALIAS, KEY_PASS) from the Android build action call.
.github/workflows/push.yml
Removed iOS signing and certificate setup steps.
  • Removed the iOS key preparation step.
  • Removed the iOS certificate setup step.
.github/workflows/push.yml
Modified artifact handling and deployment steps.
  • Commented out the condition for the 'Upload APK/AAB to apk branch' step, causing it to upload an unsigned APK.
  • Disabled the 'Push app in open testing track' (Android) step by commenting out its condition.
  • Disabled the 'Push app to testflight' (iOS) step by commenting out its condition.
.github/workflows/push.yml

Assessment against linked issues

Issue Objective Addressed Explanation
#2 Create a GitHub workflow to build apps on merged PRs into the app branch.
#2 Build apk for Android and upload to the app branch.
#2 Build ipa file for iOS and upload to the app branch. The PR only uploads unsigned APKs for Android. It does not address building and uploading ipa files for iOS.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@kienvo kienvo closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add automatic app builds on merged PRs into the app branch

1 participant