feat: Editable Canvas using pro_image_editor package#31
Merged
mariobehling merged 4 commits intofossasia:mainfrom May 29, 2025
Merged
feat: Editable Canvas using pro_image_editor package#31mariobehling merged 4 commits intofossasia:mainfrom
mariobehling merged 4 commits intofossasia:mainfrom
Conversation
Contributor
Reviewer's GuideThis pull request implements an editable canvas feature by integrating the File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @Vishveshwara - I've reviewed your changes - here's some feedback:
- Consider refactoring the editor integration by extracting only essential functionalities from the example files rather than incorporating them wholesale, to tailor it better to the app's needs.
- Abstract hardcoded values (e.g., canvas dimensions like 240x416, asset paths like 'assets/canvas/...') found within
movable_background_image.dartto improve configurability and maintainability.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+44
to
+53
| TextButton( | ||
| onPressed: () async { | ||
| final canvasBytes = await Navigator.of(context).push<Uint8List>( | ||
| MaterialPageRoute( | ||
| builder: (context) => const MovableBackgroundImageExample(), | ||
| ), | ||
| ); | ||
| imgLoader.updateImage( | ||
| bytes: canvasBytes!, | ||
| width: epd.width, |
Contributor
There was a problem hiding this comment.
issue: Guard against null return from Navigator.push before force unwrapping.
Check for null canvasBytes before calling updateImage instead of force-unwrapping it.
Comment on lines
+35
to
+40
| final decoded = img.decodeImage(bytes); | ||
| if (decoded != null) { | ||
| final resized = img.copyResize(decoded, width: width, height: height); | ||
| image = resized; | ||
| notifyListeners(); | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion: Add error handling for image decoding failures.
Log a warning or provide a fallback when decoding returns null to help diagnose failures.
Suggested change
| final decoded = img.decodeImage(bytes); | |
| if (decoded != null) { | |
| final resized = img.copyResize(decoded, width: width, height: height); | |
| image = resized; | |
| notifyListeners(); | |
| } | |
| final decoded = img.decodeImage(bytes); | |
| if (decoded != null) { | |
| final resized = img.copyResize(decoded, width: width, height: height); | |
| image = resized; | |
| notifyListeners(); | |
| } else { | |
| debugPrint("Warning: Failed to decode image from bytes."); | |
| } |
Contributor
Author
|
@AsCress @kienvo can you please give your opinions on using the pro_image_editor package You can open this link below to find more features we can possibly use. |
Dhruv1797
approved these changes
May 27, 2025
Vishveshwara
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #27
Changes
Recording
https://github.com/user-attachments/assets/b2710232-bdb1-4b9a-98ba-0e70db34fa79
Summary by Sourcery
Implement an editable canvas feature using the pro_image_editor package, enabling users to create and manipulate images with multiple editing capabilities
New Features:
Enhancements: