Skip to content

Fix: updated refresh message format and added missing UI labels #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aryan-Singla wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix: updated refresh message format and added missing UI labels #333

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09d8e97
Fix: updated refresh message format and added missing UI labels
Aryan-Singla Mar 2, 2026
49ed59e
fix: update localization labels and waveform snackbar with placeholders
Aryan-Singla Apr 15, 2026
27b472e
Revert "fix: update localization labels and waveform snackbar with pl…
Aryan-Singla Apr 15, 2026
df5b024
fix: update localization labels and waveform snackbar with placeholders
Aryan-Singla Apr 15, 2026
2975c97
Merge branch 'main' into fix/refresh-text-and-ui-labels
mariobehling Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@
"waveformSelected": "Selected",
"barcode": "Barcode",
"library": "Library",
"text": "Text",
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added text string lacks an accompanying metadata entry (e.g., @text) with a description/context. Adding metadata helps translators understand where/how the label is used (button label vs. tab title, etc.) and reduces the chance of incorrect translations.

Suggested change
"text": "Text",
"text": "Text",
"@text": {
"description": "Label for the text section or tool in the user interface."
},

Copilot uses AI. Check for mistakes.
"templates": "Templates",
"barcodeGenerator": "Barcode Generator",
"barcodeData": "Barcode Data",
Expand Down
57 changes: 48 additions & 9 deletions lib/l10n/app_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ abstract class AppLocalizations {
Locale('id'),
Locale('ja'),
Locale('nb'),
Locale('nb', 'NO'),
Locale('pt'),
Locale('pt', 'BR'),
Locale('ru'),
Expand Down Expand Up @@ -1140,6 +1139,12 @@ abstract class AppLocalizations {
/// **'Library'**
String get library;

/// No description provided for @text.
///
/// In en, this message translates to:
/// **'Text'**
String get text;

/// No description provided for @templates.
///
/// In en, this message translates to:
Expand Down Expand Up @@ -2597,6 +2602,48 @@ abstract class AppLocalizations {
/// In en, this message translates to:
/// **'Choose image from gallery'**
String get chooseImageFromGallery;

/// No description provided for @processingImages.
///
/// In en, this message translates to:
/// **'Processing images...'**
String get processingImages;

/// No description provided for @refreshModeInfo.
///
/// In en, this message translates to:
/// **'Refresh Mode Information'**
String get refreshModeInfo;

/// No description provided for @fullRefreshInfo.
///
/// In en, this message translates to:
/// **'Full Refresh'**
String get fullRefreshInfo;

/// No description provided for @fullRefreshDescription.
///
/// In en, this message translates to:
/// **'Completely refreshes the entire display by clearing all pixels and redrawing the image. This provides the best image quality and contrast but takes longer to complete.'**
String get fullRefreshDescription;

/// No description provided for @partialRefreshInfo.
///
/// In en, this message translates to:
/// **'Partial Refresh (Waveforms)'**
String get partialRefreshInfo;

/// No description provided for @partialRefreshDescription.
///
/// In en, this message translates to:
/// **'Updates only the changed pixels using optimized waveforms. This is faster than full refresh but may result in ghosting or reduced contrast over time.'**
String get partialRefreshDescription;

/// No description provided for @longPressForInfo.
///
/// In en, this message translates to:
/// **'Long press for more information'**
String get longPressForInfo;
}

class _AppLocalizationsDelegate
Expand Down Expand Up @@ -2647,14 +2694,6 @@ AppLocalizations lookupAppLocalizations(Locale locale) {

// Lookup logic when language+country codes are specified.
switch (locale.languageCode) {
case 'nb':
{
switch (locale.countryCode) {
case 'NO':
return AppLocalizationsNbNo();
}
break;
}
case 'pt':
{
switch (locale.countryCode) {
Expand Down
26 changes: 26 additions & 0 deletions lib/l10n/app_localizations_de.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,9 @@ class AppLocalizationsDe extends AppLocalizations {
@override
String get library => 'Library';

@override
String get text => 'Text';
Comment on lines +530 to +531
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description claims these new strings are localized 'across all supported languages', but multiple non-English locale implementations are currently returning English values for newly added keys (e.g., German shown here). Either provide translations for these locales (preferably via per-locale ARB files) or adjust the PR description to reflect that some locales intentionally fall back to English for the new strings.

Copilot uses AI. Check for mistakes.

@override
String get templates => 'Templates';

Expand Down Expand Up @@ -1282,4 +1285,27 @@ class AppLocalizationsDe extends AppLocalizations {

@override
String get chooseImageFromGallery => 'Choose image from gallery';

@override
String get processingImages => 'Processing images...';

@override
String get refreshModeInfo => 'Refresh Mode Information';
Comment on lines +1289 to +1293
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description claims these new strings are localized 'across all supported languages', but multiple non-English locale implementations are currently returning English values for newly added keys (e.g., German shown here). Either provide translations for these locales (preferably via per-locale ARB files) or adjust the PR description to reflect that some locales intentionally fall back to English for the new strings.

Copilot uses AI. Check for mistakes.

@override
String get fullRefreshInfo => 'Full Refresh';

@override
String get fullRefreshDescription =>
'Completely refreshes the entire display by clearing all pixels and redrawing the image. This provides the best image quality and contrast but takes longer to complete.';

@override
String get partialRefreshInfo => 'Partial Refresh (Waveforms)';

@override
String get partialRefreshDescription =>
'Updates only the changed pixels using optimized waveforms. This is faster than full refresh but may result in ghosting or reduced contrast over time.';

@override
String get longPressForInfo => 'Long press for more information';
}
26 changes: 26 additions & 0 deletions lib/l10n/app_localizations_en.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,9 @@ class AppLocalizationsEn extends AppLocalizations {
@override
String get library => 'Library';

@override
String get text => 'Text';
Comment on lines +530 to +531
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app_localizations_*.dart files appear to be Flutter gen-l10n generated outputs. Editing these directly is brittle (changes will be overwritten on the next flutter gen-l10n run and can drift from the ARB sources). Prefer making changes in the ARB files under lib/l10n/ (e.g., app_en.arb, app_de.arb, etc.) and regenerating localization Dart files via the standard build step.

Copilot uses AI. Check for mistakes.

@override
String get templates => 'Templates';

Expand Down Expand Up @@ -1282,4 +1285,27 @@ class AppLocalizationsEn extends AppLocalizations {

@override
String get chooseImageFromGallery => 'Choose image from gallery';

@override
String get processingImages => 'Processing images...';

@override
String get refreshModeInfo => 'Refresh Mode Information';

@override
String get fullRefreshInfo => 'Full Refresh';

@override
String get fullRefreshDescription =>
'Completely refreshes the entire display by clearing all pixels and redrawing the image. This provides the best image quality and contrast but takes longer to complete.';

@override
String get partialRefreshInfo => 'Partial Refresh (Waveforms)';

@override
String get partialRefreshDescription =>
'Updates only the changed pixels using optimized waveforms. This is faster than full refresh but may result in ghosting or reduced contrast over time.';

@override
String get longPressForInfo => 'Long press for more information';
}
26 changes: 26 additions & 0 deletions lib/l10n/app_localizations_es.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,9 @@ class AppLocalizationsEs extends AppLocalizations {
@override
String get library => 'Library';

@override
String get text => 'Text';

@override
String get templates => 'Templates';

Expand Down Expand Up @@ -1282,4 +1285,27 @@ class AppLocalizationsEs extends AppLocalizations {

@override
String get chooseImageFromGallery => 'Choose image from gallery';

@override
String get processingImages => 'Processing images...';

@override
String get refreshModeInfo => 'Refresh Mode Information';

@override
String get fullRefreshInfo => 'Full Refresh';

@override
String get fullRefreshDescription =>
'Completely refreshes the entire display by clearing all pixels and redrawing the image. This provides the best image quality and contrast but takes longer to complete.';

@override
String get partialRefreshInfo => 'Partial Refresh (Waveforms)';

@override
String get partialRefreshDescription =>
'Updates only the changed pixels using optimized waveforms. This is faster than full refresh but may result in ghosting or reduced contrast over time.';

@override
String get longPressForInfo => 'Long press for more information';
}
26 changes: 26 additions & 0 deletions lib/l10n/app_localizations_fr.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,9 @@ class AppLocalizationsFr extends AppLocalizations {
@override
String get library => 'Library';

@override
String get text => 'Text';

@override
String get templates => 'Templates';

Expand Down Expand Up @@ -1282,4 +1285,27 @@ class AppLocalizationsFr extends AppLocalizations {

@override
String get chooseImageFromGallery => 'Choose image from gallery';

@override
String get processingImages => 'Processing images...';

@override
String get refreshModeInfo => 'Refresh Mode Information';

@override
String get fullRefreshInfo => 'Full Refresh';

@override
String get fullRefreshDescription =>
'Completely refreshes the entire display by clearing all pixels and redrawing the image. This provides the best image quality and contrast but takes longer to complete.';

@override
String get partialRefreshInfo => 'Partial Refresh (Waveforms)';

@override
String get partialRefreshDescription =>
'Updates only the changed pixels using optimized waveforms. This is faster than full refresh but may result in ghosting or reduced contrast over time.';

@override
String get longPressForInfo => 'Long press for more information';
}
Loading