fix: movable background issue

[Dhruv1797]

Fixes #33 – Resolved an issue where the background image could be unintentionally moved while editing. The update ensures the background stays fixed, allowing only the foreground elements (like drawings or overlays) to be interactive and draggable.

Summary by Sourcery

Disable all interactive operations on the background layer to prevent unintentional movement and ensure only foreground elements remain draggable.

Bug Fixes:

• Prevent background image from being moved, edited, rotated, scaled, or selected during editing.

Enhancements:

• Introduce LayerInteraction model to explicitly configure and disable interactions on the background layer.

[sourcery-ai]

Reviewer's Guide

The PR fixes unintended background movement by importing the LayerInteraction model and configuring the background WidgetLayer to disable all interaction flags, ensuring only foreground elements remain interactive.

Sequence Diagram: Handling Background Drag Attempt Post-Fix

sequenceDiagram
    actor User
    participant Editor
    participant BackgroundWidgetLayer

    User->>Editor: Attempts to drag background image
    Editor->>BackgroundWidgetLayer: processInteraction(type="drag")
    %% BackgroundWidgetLayer now has interaction.enableMove = false
    BackgroundWidgetLayer-->>Editor: interactionPrevented(type="drag")
    Editor-->>User: Background image remains fixed

Loading

Class Diagram: Configuration of WidgetLayer Interaction

classDiagram
  class LayerInteraction {
    +enableEdit: bool = false
    +enableMove: bool = false
    +enableRotate: bool = false
    +enableScale: bool = false
    +enableSelection: bool = false
    +LayerInteraction(enableEdit: bool, enableMove: bool, enableRotate: bool, enableScale: bool, enableSelection: bool)
  }
  class WidgetLayer {
    +interaction: LayerInteraction
    +offset: Offset
    +scale: double
    +widget: Image
    +WidgetLayer(interaction: LayerInteraction, offset: Offset, scale: double, widget: Image)
  }
  WidgetLayer "1" *-- "1" LayerInteraction : uses

Loading

File-Level Changes

Change	Details	Files
Disable interactive operations on the background layer	Added import of LayerInteraction model Updated replaceLayer call to include a LayerInteraction with all flags set to false	lib/pro_image_editor/features/movable_background_image.dart

Possibly linked issues

• Background Canvas Should Be Fixed and Non-Movable in Editor #33: The PR fixes the movable background issue by disabling interaction for the canvas layer.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @Dhruv1797 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[AsCress]

@Dhruv1797 Looks good ! However, could you please add a demo showing what exactly this solves ?

[Dhruv1797]

this is the previous behaviour where where the background could be unintentionally moved while editing.

previous_behaviour.mp4

now this is the updated behaviour where background stays fixed, allowing only the foreground elements to be interactive and draggable

updated_behaviour.mp4

@AsCress please review it.

[AsCress]

@Dhruv1797 Thanks for the explanation !