feat: quick waveform luts#70
Closed
kienvo wants to merge 1 commit intofossasia:mainfrom
Closed
Conversation
Contributor
Reviewer's GuideThis PR introduces a dedicated waveform abstraction with a new QuickLut subclass, integrates custom quick LUTs and panel settings into the UC8253 driver initialization, extends the Driver interface accordingly, and refactors the Protocol class to centralize NFC messaging and eliminate explicit tagId parameters. Class diagram for new waveform abstraction and QuickLutclassDiagram
class Lut {
+int cmd
+Uint8List data
}
class Waveform {
<<abstract>>
+String desc
+int pll
+List~Lut~ luts
}
class QuickLut {
+desc
+pll
+luts
}
Waveform <|-- QuickLut
Class diagram for updated Driver and Uc8253 integrationclassDiagram
class Driver {
<<abstract>>
+String driverName
+List~int~ transmissionLines
+int refresh
+int vcomLut
+int wwLut
+int bwLut
+int wbLut
+int bbLut
+int panelSetting
+int pllControl
+WaveformList waveforms
+Future<void> setlut(Protocol, Waveform)
+Future<void> init(Protocol)
}
class Uc8253 {
+refresh
+vcomLut
+wwLut
+bwLut
+wbLut
+bbLut
+panelSetting
+pllControl
+waveforms
+setlut(Protocol, Waveform)
+init(Protocol)
}
Driver <|-- Uc8253
Uc8253 --> QuickLut : uses
Class diagram for Protocol refactor (centralized NFC messaging)classDiagram
class Protocol {
+MagicEpaperFirmware fw
+Epd epd
+Duration timeout
+Uint8List tagId
+writeMsg(Uint8List)
+_readDynCfg(int)
+_writeDynCfg(int, int)
+hasI2cGatheredMsg()
+enableEnergyHarvesting()
+wait4msgGathered()
+writeFrame(Uint8List, Uint8List, int)
+writeImage(Uint8List)
}
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
85a6ab8 to
8cd5960
Compare
marcnause
reviewed
Jun 30, 2025
| [p.fw.epdSend, 0xCF, 0x8D])); // 480x240, built-in LUTs | ||
|
|
||
| // await p.writeMsg(Uint8List.fromList([p.fw.epdSend, 0xEF, 0x8D])); // 480x240, LUTs from register | ||
| // await setlut(p, waveforms[0]); |
There was a problem hiding this comment.
Commented out code should usually not be committed. Is there a good reason to do it here?
Member
Author
There was a problem hiding this comment.
It was left here to guide #77 for @Dhruv1797 and @Vishveshwara to work on, otherwise they won't know what 0xEF, 0x8D means.
Member
|
@kienvo please resolve conflicts |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #59
Summary by Sourcery
Add quick waveform LUT support to the UC8253 display driver and refactor protocol and driver interfaces to streamline LUT loading and NFC message handling
New Features:
Enhancements: