Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated multimeter screen layout to make it visible properly #2407

Merged
merged 1 commit into from
May 16, 2024

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented May 16, 2024

Fixes #2342 and #2394
This issue was arising due to a redundant View bottom_view being present in the layouts, something which has already been implemented in activity_multimeter_main.xml.

Changes

  • app/src/main/res/layout-hdpi/activity_multimeter.xml,
    app/src/main/res/layout-sw600dp/activity_multimeter.xml,
    app/src/main/res/layout-xhdpi/activity_multimeter.xml,
    app/src/main/res/layout/activity_multimeter.xml - Removed bottom_view and fixed some other constraints, hardcoding.
  • app/src/main/res/values-hdpi/dimens.xml,
    app/src/main/res/values/dimens.xml - Fixed some dimensions and added others to improve the layouts.

Screenshots / Recordings

  • app/src/main/res/layout-xhdpi/activity_multimeter.xml:-
    multimeter_screenshot_1
  • app/src/main/res/layout-hdpi/activity_multimeter.xml:-
    Screenshot 2024-05-16 155425
  • app/src/main/res/layout-sw600dp/activity_multimeter.xml:-
    Screenshot 2024-05-16 155527

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

@CloudyPadmal CloudyPadmal merged commit 673f988 into fossasia:development May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multimeter screen layout incomplete
2 participants