Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed pol values and fixed gradle build files to support correct languages #2413

Merged
merged 1 commit into from
May 16, 2024

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented May 16, 2024

Fixes #2410
Removes the values/pol/string.xml file and updates the build.gradle.kts file to only support valid languages, as the correct file for Polish language (values/pl/strings.xml) is already present.

Changes

  • app/src/main/res/values-pol/string.xml - File removed
  • app/build.gradle.kts - resConfig property added

Screenshots / Recordings

N/A

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Instead of removing the Polish language entirely, could you just rename it to "pl", please?

@AsCress
Copy link
Collaborator Author

AsCress commented May 16, 2024

Thank you. Instead of removing the Polish language entirely, could you just rename it to "pl", please?

I've not removed the Polish language. There is already a proper file existing for the polish language, the 'pl' file. I've just removed the redundant 'pol' one, which was causing the issue. I've specified the Polish language in the resConfig property, and the existing 'pl' file is perfectly usable.

@adityastic adityastic merged commit 17083ea into fossasia:development May 16, 2024
2 checks passed
@AsCress AsCress deleted the removeValues branch May 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: App uses pol instead of pl for Polish Language
3 participants