-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialized Oscilloscope Screen #2612
Draft
AsCress
wants to merge
2
commits into
fossasia:flutter
Choose a base branch
from
AsCress:flutter_oscilloscope
base: flutter
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,676
−139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR initializes the Oscilloscope screen UI, including layouts for channel parameters, timebase/trigger settings, data analysis, and XY plotting. It also refactors the navigation drawer and application list items. Class diagram for the Oscilloscope screen componentsclassDiagram
class OscilloscopeScreen {
+initState()
+build()
-_setLandscapeOrientation()
}
class OscilloscopeStateProvider {
-int _selectedIndex
+int selectedIndex
+updateSelectedIndex(int)
}
class ChannelParametersWidget {
+build()
}
class TimebaseTriggerWidget {
+build()
}
class DataAnalysisWidget {
+build()
}
class XYPlotWidget {
+build()
}
class OscilloscopeScreenTabs {
+String channelParametersImage
+String dataAnalysisImage
+String timebaseTriggerImage
+String xyPlotImage
+build()
}
OscilloscopeScreen --> OscilloscopeStateProvider
OscilloscopeScreen --> ChannelParametersWidget
OscilloscopeScreen --> TimebaseTriggerWidget
OscilloscopeScreen --> DataAnalysisWidget
OscilloscopeScreen --> XYPlotWidget
OscilloscopeScreen --> OscilloscopeScreenTabs
State diagram for Oscilloscope screen tabsstateDiagram-v2
[*] --> Channels
Channels --> Timebase: Tab switch
Timebase --> DataAnalysis: Tab switch
DataAnalysis --> XYPlot: Tab switch
XYPlot --> Channels: Tab switch
state Channels {
[*] --> ChannelParameters
ChannelParameters: CH1/CH2/CH3/MIC settings
}
state Timebase {
[*] --> TimebaseTrigger
TimebaseTrigger: Trigger and timebase settings
}
state DataAnalysis {
[*] --> Analysis
Analysis: Fourier transforms
Analysis: Signal analysis
}
state XYPlot {
[*] --> XYPlotting
XYPlotting: XY plot configuration
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
AsCress
force-pushed
the
flutter_oscilloscope
branch
2 times, most recently
from
January 17, 2025 11:35
eab7d3a
to
7917e13
Compare
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/12846202916/artifacts/2451327943 |
AsCress
force-pushed
the
flutter_oscilloscope
branch
from
January 18, 2025 17:56
9c12e80
to
900b663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly and steadily, we would get there 🥹.
This is currently a Work In Progress.
Initializes the Oscilloscope Screen in our flutter app.
Screenshots / Recordings
Here's what we have as of now:
Screen_recording_20250118_232441.mp4
The layouts are done, functionality coming soon.
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.@marcnause Would you like to test these layouts 😉 ?