fix: gyroscope screen crash and UI

[rahul31124]

Bug Fixes
The gyroscope screen was crashing and the gyroscope screen ui was not properly visible in landscape mode

Exception
java.lang.IllegalStateException: Fragment GyroscopeDataFragment{9c6c7cf} (e25b37d6-0238-4496-aaa5-74f0d1aa9d93) not attached to a context.

Changes

Added checks to ensure fragments are properly attached before accessing context (isAdded() and fragment.isAdded() checks)
Used safe context access for string resources with a fallback string
Used ScrollView to ensure proper UI visibility in landscape mode

Screenshots / Recordings

Before

Gyroscope_Before.mp4

After

Gyroscope_After.mp4

Checklist:

• No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
• No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
• Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
• No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Fixes a crash on the gyroscope screen and improves UI visibility in landscape mode. The fragment is now properly attached before accessing the context and a ScrollView is used to ensure proper UI visibility.

Bug Fixes:

• Fixes a crash caused by accessing the context of a fragment that is not attached.
• Fixes UI visibility issues in landscape mode on the gyroscope screen.
• Prevents the IllegalStateException: Fragment GyroscopeDataFragment not attached to a context.

Enhancements:

• Improves UI visibility in landscape mode by using ScrollView.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a crash in the gyroscope screen and improves UI visibility in landscape mode. It adds checks to ensure fragments are attached before accessing context, uses safe context access for string resources, and uses ScrollView to ensure proper UI visibility in landscape mode.

Sequence diagram for visualizeData() method

sequenceDiagram
    participant GDF as GyroscopeDataFragment
    participant GV as GyroscopeViewFragment

    GDF->GDF: isAdded()
    alt Fragment is attached
        loop for each gyroscopeViewFragment
            GDF->GV: fragment.isAdded()
            alt Fragment is attached
                GDF->GDF: timeElapsed = (System.currentTimeMillis() - startTime) / 1000
                GDF->GV: setPreviousTimeElapsed(timeElapsed)
                GDF->GV: addEntry(new Entry((float) timeElapsed, fragment.getCurrentValue()))
                GDF->GV: getContext()
                alt Context is not null
                    GDF->GV: getString(R.string.gyroscope)
                else Context is null
                    GDF->GDF: label = "Gyroscope"
                end
                GDF->GV: LineDataSet dataSet = new LineDataSet(fragment.getEntries(), label)
            end
        end
    end

Loading

Updated class diagram for GyroscopeDataFragment

classDiagram
    class GyroscopeDataFragment {
        -List~GyroscopeViewFragment~ gyroscopeViewFragments
        -long startTime
        +void visualizeData()
        +void writeLogToFile(long timestamp, float readingX, float readingY, float readingZ)
    }

    GyroscopeDataFragment -- GyroscopeViewFragment : has a

Loading

Updated class diagram for fragment_gyroscope_data.xml

classDiagram
    class ScrollView {
        ---
    }
    class LinearLayout{
       ---
    }
    class Fragment{
       ---
    }

    ScrollView o-- LinearLayout : contains
    LinearLayout o-- Fragment : contains
    LinearLayout o-- Fragment : contains
    LinearLayout o-- Fragment : contains

Loading

File-Level Changes

Change	Details	Files
Added checks to ensure fragments are properly attached before accessing context to prevent crashes.	Added isAdded() check before accessing the context in visualizeData(). Added fragment.isAdded() check before using the fragment in visualizeData().	app/src/main/java/io/pslab/fragment/GyroscopeDataFragment.java
Implemented safe context access for string resources with a fallback string.	Used a ternary operator to provide a fallback string if the context is null when creating the LineDataSet.	app/src/main/java/io/pslab/fragment/GyroscopeDataFragment.java
Used ScrollView to ensure proper UI visibility in landscape mode.	Wrapped the LinearLayout containing the fragments with a ScrollView. Changed the height of the fragments to a fixed dp value.	app/src/main/res/layout/fragment_gyroscope_data.xml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rahul31124 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The addition of isAdded() checks is good for preventing crashes, but consider whether there are alternative ways to handle the lifecycle of these fragments.
• Using hardcoded values like android:layout_height="300dp" should be avoided; consider using a dimension resource instead.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/13923861898/artifacts/2772510925

[AsCress]

@rahul31124 Thanks for your work. Could you please fix all the hardcoded dimensions ?

[rahul31124]

Hi @AsCress , I have fixed all the hardcoded dimensions now I guess everything looks good