fix: crash in robotic arm activity

[rahul31124]

Crash Fix
The Robotic Arm screen was crashing due to a java.lang.NumberFormatException when the EditText view was empty and the "Done" button was pressed

Exception
java.lang.NumberFormatException: For input string: ""
at java.lang.Integer.parseInt(Integer.java:807)
at java.lang.Integer.valueOf(Integer.java:1128)
at io.pslab.activity.RoboticArmActivity$15.onEditorAction(RoboticArmActivity.java:436)
at android.widget.TextView.onEditorAction(TextView.java:7967)

Changes

Added validation to check if the EditText is empty before parsing the value.
If the input is empty, the previous valid value is restored.

Screenshots / Recordings

Before
Robotic_Arm_Before.webm
After
Robotic_Arm_After.webm

Checklist:

• No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
• No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
• Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
• No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Bug Fixes:

• Fixes a NumberFormatException crash in the Robotic Arm activity when the degree input field is empty.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a crash in the Robotic Arm activity that occurred when the app tried to parse an empty string to an integer. To fix this, the code was modified to validate the input from the EditText fields. If the input is empty, the code now restores the previous valid value.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added validation to prevent NumberFormatException when parsing empty EditText input.	Added a check to see if the EditText input is empty. If the input is empty, the previous valid degree value is restored. If the input is not empty, the degree value is parsed from the EditText input.	app/src/main/java/io/pslab/activity/RoboticArmActivity.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rahul31124 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider refactoring the duplicated code into a separate method to improve readability and maintainability.
• The logic for restoring the previous degree when the input is empty could be simplified.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Consider consolidating similar logic into a helper method.

The same pattern of retrieving, trimming, checking if empty, and conditionally setting the 'degree' value is repeated for each text field. Extracting the common logic into a private helper method would reduce duplication and make future maintenance easier.

[sourcery-ai]

issue (complexity): Consider extracting the duplicated degree parsing and updating logic into a helper method to reduce redundancy and improve code maintainability by calling the helper method in each listener with the corresponding text view and seek arc parameters, instead of repeating the logic in each listener.

Consider centralizing the duplicated degree parsing/updating logic into a helper method. This avoids duplicating the if/else statements and state updates in each listener. For example, you could do the following:

1. Extract a Helper Method

   Define a method that processes the degree input and updates the associated seek arc:

   private void processDegreeInput(TextView degreeText, SeekArc seekArc) {
       int previousDegree = degree;
       String degreeStr = degreeText.getText().toString().trim();
       if (degreeStr.isEmpty()) {
           degree = (degree == 0) ? (int) (seekArc.getProgress() * 3.6) : previousDegree;
       } else {
           degree = Integer.parseInt(degreeStr);
       }
   
       if (degree > 360 || degree < 0) {
           degreeText.setText(getResources().getString(R.string.zero));
           seekArc.setProgress(0);
           toastInvalidValueMessage();
       } else {
           seekArc.setProgress((int) (degree / 3.6));
           editEnter = true;
       }
   }

2. Refactor Each Listener

   Then update each OnEditorActionListener to call this method:

   degreeText1.setOnEditorActionListener(new TextView.OnEditorActionListener() {
       @Override
       public boolean onEditorAction(TextView v, int actionId, KeyEvent event) {
           removeStatusBar();
           if (actionId == EditorInfo.IME_ACTION_DONE) {
               processDegreeInput(degreeText1, seekArc1);
           }
           return false;
       }
   });

   Repeat similarly for degreeText2, degreeText3, and degreeText4, passing the corresponding seek arc.

These steps reduce duplicate code while preserving existing functionality.

[github-actions]

Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/13923868879/artifacts/2772511544