Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate Bluetooth Permissions #2655

Merged

Conversation

rahul31124
Copy link
Contributor

@rahul31124 rahul31124 commented Mar 17, 2025

Fixes #2648

Changes

Removed duplicate Bluetooth permissions (android.permission.BLUETOOTH and android.permission.BLUETOOTH_ADMIN) from AndroidManifest.xml files

Screenshots / Recordings

NA

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Bug Fixes:

  • Removes duplicate Bluetooth permissions (android.permission.BLUETOOTH and android.permission.BLUETOOTH_ADMIN) from AndroidManifest.xml files

Copy link

sourcery-ai bot commented Mar 17, 2025

Reviewer's Guide by Sourcery

This pull request removes duplicate Bluetooth permissions from the AndroidManifest.xml files. The permissions android.permission.BLUETOOTH and android.permission.BLUETOOTH_ADMIN were removed from both the debug and main manifests.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removal of duplicate Bluetooth permissions.
  • Removed android.permission.BLUETOOTH from the debug manifest.
  • Removed android.permission.BLUETOOTH_ADMIN from the debug manifest.
  • Removed android.permission.BLUETOOTH from the main manifest.
  • Removed android.permission.BLUETOOTH_ADMIN from the main manifest.
app/src/debug/AndroidManifest.xml
app/src/main/AndroidManifest.xml

Assessment against linked issues

Issue Objective Addressed Explanation
#2648 Remove duplicate Bluetooth permissions from AndroidManifest.xml.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rahul31124 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider if these permissions should be removed from both debug and main manifests, or if they are only unnecessary in one.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Mar 17, 2025

@AsCress AsCress changed the title fix: Remove duplicate Bluetooth permissions in AndroidManifest fix: remove duplicate Bluetooth Permissions Mar 18, 2025
@AsCress AsCress force-pushed the fix-duplicate-bluetooth-permissions branch from 9e26e56 to 1ff90a5 Compare March 18, 2025 12:52
@AsCress AsCress enabled auto-merge (squash) March 18, 2025 12:52
Copy link
Collaborator

@AsCress AsCress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much !

@AsCress AsCress added the Fix Solution to an existing issue in app label Mar 18, 2025
@AsCress AsCress merged commit b20040c into fossasia:development Mar 18, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AndroidManifest.xml contains duplicate entries for Bluetooth permissions
2 participants