Skip to content

feat: implemented LUX meter#2733

Merged
AsCress merged 5 commits into
fossasia:flutterfrom
Yugesh-Kumar-S:lux-meter-screen
Jun 13, 2025
Merged

feat: implemented LUX meter#2733
AsCress merged 5 commits into
fossasia:flutterfrom
Yugesh-Kumar-S:lux-meter-screen

Conversation

@Yugesh-Kumar-S

@Yugesh-Kumar-S Yugesh-Kumar-S commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #2731

Changes

  • Ported the lux meter instrument.
  • Created a custom gauge meter.
  • Adapted dark mode to lux meter

Screenshots / Recordings

Screen_recording_20250611_020636.mp4

Updated view
Screenshot_20250612-185443

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

@github-actions

github-actions Bot commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/15611757571/artifacts/3314577654

@sourcery-ai

sourcery-ai Bot commented Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🧙 Sourcery is reviewing your pull request!

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Yugesh-Kumar-S Yugesh-Kumar-S added flutter Status: Review Required Requested reviews from peers and maintainers labels Jun 12, 2025
@mariobehling mariobehling requested a review from marcnause June 12, 2025 08:41
@Yugesh-Kumar-S Yugesh-Kumar-S requested a review from AsCress June 13, 2025 11:20
@Yugesh-Kumar-S

Yugesh-Kumar-S commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

@AsCress I have changed the card view as suggested, please review it and merge if its good.

@AsCress

AsCress commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Layout tweeks kept for later:

  1. Adjust the graph to be in the center.
  2. Fix rounded edges for the graph.

@AsCress AsCress merged commit 1169df0 into fossasia:flutter Jun 13, 2025
6 checks passed
Yugesh-Kumar-S added a commit to Yugesh-Kumar-S/pslab-android that referenced this pull request Jun 13, 2025
@Yugesh-Kumar-S
# This is a combination of 7 commits.
35c9476 
# This is the 1st commit message:

Implemented LUX meter

# This is the commit message #2:

added const

# This is the commit message fossasia#3:

Improved responsiveness and made reusable widgets

# This is the commit message fossasia#4:

renamed file

# This is the commit message fossasia#5:

Updated view as per PSLab

# This is the commit message fossasia#6:

Implemented sound meter

# This is the commit message fossasia#7:

feat: implemented LUX meter (fossasia#2733)

fix: handled theming for instrument screens (fossasia#2732)

chore(deps): bump org.jetbrains.kotlin.android in /android

Bumps [org.jetbrains.kotlin.android](https://github.com/JetBrains/kotlin) from 1.8.22 to 2.1.21.
- [Release notes](https://github.com/JetBrains/kotlin/releases)
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md)
- [Commits](JetBrains/kotlin@v1.8.22...v2.1.21)

---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin.android
  dependency-version: 2.1.21
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Adjusted view

Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcnause marcnause Awaiting requested review from marcnause
1 more reviewer
@AsCress AsCress AsCress approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flutter Status: Review Required Requested reviews from peers and maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lux Meter UI and real-time light measurement

2 participants

@Yugesh-Kumar-S @AsCress