-
Notifications
You must be signed in to change notification settings - Fork 825
fix: orientation not resetting #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideIntroduced a dispose override in the RoboticArmScreen state to invoke provider resource cleanup before calling super.dispose(), ensuring the screen orientation resets correctly. Sequence diagram for RoboticArmScreen disposal and orientation resetsequenceDiagram
participant RoboticArmScreenState
participant Provider
RoboticArmScreenState->>Provider: disposeResources()
RoboticArmScreenState->>State: super.dispose()
Class diagram for updated RoboticArmScreen resource disposalclassDiagram
class _RoboticArmScreenState {
+dispose()
-provider: ProviderType
}
_RoboticArmScreenState :> State
_RoboticArmScreenState --> ProviderType : uses
class ProviderType {
+disposeResources()
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AsCress
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @rahul31124 You've verified that this works, right ?
@AsCress Yes I have verified that |
|
Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/17022274293/artifacts/3783076346 |
|
CC: @marcnause Good to go. |
Fixes #2831
Changes
dispose()method inrobotic_arm_screen.dart.dispose(), calledprovider.disposeResources()so that the screen’s orientation is reset properly.Summary by Sourcery
Bug Fixes: