-
Notifications
You must be signed in to change notification settings - Fork 825
fix: multimeter knob UI #2865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multimeter knob UI #2865
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces dynamic size-based dial drawing and conditional widget sizing with fixed responsive dimensions to ensure consistent knob rendering across screen sizes. Class diagram for updated multimeter knob widget renderingclassDiagram
class InnerDialPainter {
+paint(Canvas, Size)
-radius: double (changed to 105.r)
}
class InnerDialFillPainter {
+paint(Canvas, Size)
-radius: double (changed to 105.r)
}
class InnerPointerPainter {
+paint(Canvas, Size)
-radius: double (changed to 105.r)
-pointerPaint.strokeCap: StrokeCap (changed to butt)
-pointerStartInner: Offset (radius changed to 1.0)
-pointerEndInner: Offset (radius changed to 0.77)
}
class _MultimeterKnobState {
-SizedBox.width: double (changed to 300.w)
-SizedBox.height: double (changed to 300.h)
}
MultimeterKnob <|-- _MultimeterKnobState
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/17118554174/artifacts/3815921472 |
Fixes the multimeter knob UI which was still rendered incorrectly on some screen sizes.
Screenshots / Recordings:
Summary by Sourcery
Standardize multimeter knob UI dimensions and pointer styling to ensure consistent rendering across screen sizes
Bug Fixes: