chore: fix screenshot workflows #2866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR refactors and enhances the screenshot capture workflows across PR comments and CI pipelines by splitting iPhone and iPad pipelines, updating default device models, enforcing timeouts, removing redundant steps, and correctly targeting simulators via UDIDs. Sequence diagram for iPhone screenshot workflow with UDID targetingsequenceDiagram
participant CI as CI Workflow
participant Xcode as Set up Xcode
participant Checkout as Checkout Repo
participant Sim as Create iPhone Simulator
participant Flutter as Flutter Drive
participant Artifact as Upload Artifact
CI->>Xcode: Set up Xcode
Xcode->>Checkout: Checkout repository
Checkout->>Sim: Create iPhone Simulator (get UDID)
Sim->>Flutter: Pass UDID to flutter drive
Flutter->>Artifact: Capture and upload iPhone screenshots
Sequence diagram for iPad screenshot workflow with UDID targetingsequenceDiagram
participant CI as CI Workflow
participant Xcode as Set up Xcode
participant Checkout as Checkout Repo
participant Sim as Create iPad Simulator
participant Flutter as Flutter Drive
participant Artifact as Upload Artifact
CI->>Xcode: Set up Xcode
Xcode->>Checkout: Checkout repository
Checkout->>Sim: Create iPad Simulator (get UDID)
Sim->>Flutter: Pass UDID to flutter drive
Flutter->>Artifact: Capture and upload iPad screenshots
Class diagram for updated screenshot workflow actionsclassDiagram
class ScreenshotIphoneAction {
+IPHONE_DEVICE_MODEL: string
+Create iPhone Simulator (outputs UDID)
+Capture iPhone Screenshots (uses UDID)
+Upload iPhone Screenshots
}
class ScreenshotIpadAction {
+IPAD_DEVICE_MODEL: string
+Create iPad Simulator (outputs UDID)
+Capture iPad Screenshots (uses UDID)
+Upload iPad Screenshots
}
ScreenshotIphoneAction <|-- ScreenshotIpadAction
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
AsCress
force-pushed
the
pipeline_fix
branch
2 times, most recently
from
6246445 to
09189f1
Compare
Contributor
Build StatusBuild workflow failed. Please check the logs for more information. Screenshots (Android)Not able to fetch screenshots. Screenshots (iPhone)Not able to fetch screenshots. Screenshots (iPad)Not able to fetch screenshots. |
AsCress
force-pushed
the
pipeline_fix
branch
2 times, most recently
from
5813073 to
d8b0e5a
Compare
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Security Issues
### Issue 1
<location> `.github/actions/screenshot-ipad/action.yml:13` </location>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>
### Issue 2
<location> `.github/actions/screenshot-ipad/action.yml:26` </location>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>
### Issue 3
<location> `.github/workflows/pull-request.yml:98` </location>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>
### Issue 4
<location> `.github/workflows/push-event.yml:228` </location>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
bessman
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Revamp screenshot workflows by splitting iPhone and iPad capture into separate jobs and actions, updating pull-request comment logic to fetch and display both device artifacts, and adding concurrency control to the PR workflow.
Enhancements: