fix: use correct libusb dependency name for RPM packages#3112
Merged
fix: use correct libusb dependency name for RPM packages#3112
Conversation
Copilot
AI
changed the title
[WIP] Update dependency name for RPM compliance
fix: use correct libusb package name for RPM dependencies
Mar 3, 2026
marcnause
approved these changes
Mar 3, 2026
marcnause
approved these changes
Mar 3, 2026
There was a problem hiding this comment.
Pull request overview
Updates the Linux CI packaging metadata so RPM artifacts declare a valid libusb dependency on RPM-based distros, addressing install failures reported in #3110.
Changes:
- Switch RPM
fpm --dependsfrom the Debian/Ubuntu package namelibusb-1.0-0to the RPM package namelibusb1for x64 builds. - Apply the same RPM dependency fix to the ARM64 Linux packaging action.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/actions/linux/action.yml | Fix RPM dependency name used by fpm for x64 RPM packaging. |
| .github/actions/linux-arm64/action.yml | Fix RPM dependency name used by fpm for ARM64 RPM packaging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
marcnause
changed the title
…sb-1.0-0 Co-authored-by: marcnause <11596220+marcnause@users.noreply.github.com>
marcnause
force-pushed
the
copilot/update-dependency-for-rpm
branch
from
f249c12 to
97de0dc
Compare
Contributor
Build StatusBuild successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/22815874978/artifacts/5816284469. ScreenshotsAndroid Screenshots
iPhone Screenshots
iPad Screenshots
|
||||||||||||||||||||||||
-1_instruments_screen.png?raw=true)
-2_nav_drawer.png?raw=true)
-3_accelerometer.png?raw=true)
-4_power_source.png?raw=true)
-5_multimeter.png?raw=true)
-6_wave_generator.png?raw=true)
-7_oscilloscope.png?raw=true)
CloudyPadmal
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3110
libusb-1.0-0is a Debian/Ubuntu package name and is invalid in RPM-based distributions (Fedora/RHEL/CentOS). The RPM build steps in both Linux CI actions were incorrectly using this DEB name, causing RPM packages to declare an unresolvable dependency.Changes
.github/actions/linux-arm64/action.yml— Fix--dependsin theBuild .rpm packagestep:libusb-1.0-0→libusb1.github/actions/linux/action.yml— Same fix for the x64 variantfpm -s dir -t rpm \ -n pslab \ -v ${{ inputs.VERSION_NAME }} \ --prefix=/ \ - --depends libusb-1.0-0 \ + --depends libusb1 \DEB build steps are unchanged —
libusb-1.0-0remains correct there.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.